Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links #1445

Merged
merged 2 commits into from Aug 13, 2019
Merged

Update links #1445

merged 2 commits into from Aug 13, 2019

Conversation

atouchet
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 28, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 28, 2019

📌 Commit ed757a8 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Jul 29, 2019

⌛ Testing commit ed757a8 with merge d4f02c8...

bors added a commit that referenced this pull request Jul 29, 2019
@bors
Copy link
Contributor

bors commented Jul 29, 2019

💔 Test failed - checks-cirrus-freebsd-12

CONTRIBUTING.md Outdated
@@ -38,9 +38,9 @@ With that in mind, the steps for adding a new API are:

### Test before you commit

We have two automated tests running on [Travis](https://travis-ci.org/rust-lang/libc):
We have two automated tests running on [Travis](https://travis-ci.com/rust-lang/libc):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the Travis link be replaced with the Azure one? Also is libc-test using Azure as well? The linked repo still lists Travis in its readme.

Copy link
Contributor

@gnzlbg gnzlbg Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and yes, libc uses azure and libc-test is using azure as well.

@gnzlbg gnzlbg closed this Aug 13, 2019
@gnzlbg gnzlbg reopened this Aug 13, 2019
@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 13, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 13, 2019

📌 Commit 803cf64 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Aug 13, 2019

⌛ Testing commit 803cf64 with merge d7907c0...

bors added a commit that referenced this pull request Aug 13, 2019
@bors
Copy link
Contributor

bors commented Aug 13, 2019

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing d7907c0 to master...

@bors bors merged commit 803cf64 into rust-lang:master Aug 13, 2019
@atouchet atouchet deleted the links branch August 13, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants