Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce appveyor churn #1429

Merged
merged 1 commit into from Jul 6, 2019
Merged

Reduce appveyor churn #1429

merged 1 commit into from Jul 6, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Jul 6, 2019

This should reduce the Appveyorn churn for other projects a bit more.

Please let me know if there is anything else that can be done. Maybe the infra team could discuss whether to document some general guidelines for rust-lang and rust-lang-nursery projects, and write them down somewhere. I would be willing to help.

cc @RalfJung @Mark-Simulacrum

@rust-highfive
Copy link

@gnzlbg: no appropriate reviewer found, use r? to override

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Jul 6, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 6, 2019

📌 Commit 3f8cff7 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Jul 6, 2019

⌛ Testing commit 3f8cff7 with merge 2b351c2...

bors added a commit that referenced this pull request Jul 6, 2019
Reduce appveyor churn

This should reduce the Appveyorn churn for other projects a bit more.

Please let me know if there is anything else that can be done. Maybe the infra team could discuss whether to document some general guidelines for rust-lang and rust-lang-nursery projects, and write them down somewhere. I would be willing to help.

cc @RalfJung @Mark-Simulacrum
@bors
Copy link
Contributor

bors commented Jul 6, 2019

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 2b351c2 to master...

@bors bors merged commit 3f8cff7 into rust-lang:master Jul 6, 2019
@RalfJung
Copy link
Member

RalfJung commented Jul 9, 2019

Thanks a lot!

Another thing you could do is not run the full AppVeyor test suite on every push to every PR. Currently that's about 15min each time. Maybe running one of the 4 jobs is representative enough that the rest can be covered by bors (including try builds if you want pre-landing testing)?

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Jul 9, 2019

Maybe running one of the 4 jobs is representative enough that the rest can be covered by bors (including try builds if you want pre-landing testing)?

Sadly this isn't the case - the only thing we test here is the system ABI, and that's completely different for each of the targets running on appveyor.

What we could do is move those jobs to Azure Pipelines, once we get a green light to land #1376 .

@RalfJung
Copy link
Member

RalfJung commented Jul 9, 2019

I was thinking the same for Miri (re: moving to Azure). ;)

So, how long until we'll have congestion there? :D Do you know how many runners we collectively have there?

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Jul 9, 2019

So, how long until we'll have congestion there? :D Do you know how many runners we collectively have there?

No idea, but if rust-lang/rust ends up completely switching to Azure, I suppose the infra team will make an announcement about what their plan is, and what to do with the other repos in the org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants