Update ctest version #1419
Merged
Update ctest version #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gnzlbg: no appropriate reviewer found, use r? to override |
|
@sunfishcode @alexcrichton wasi is failing to build because the memoffset dependency couldn't be resolved, could you point me to commit hashes that are known to build ? I'll include the fix here. |
|
@bors: r+ |
|
📌 Commit 9f92863 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 5, 2019
Update ctest version The latest ctest version enabled the ABI roundtrip test by default, in which we initialize all types in Rust by default to some random bit-pattern, pass them to C, verify, modify, pass back to Rust, and verify. This catches issues in the call ABI / calling convention. This PR will silence those here for now.
|
💔 Test failed - checks-travis |
|
@bors: r+
|
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 9f92863 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 5, 2019
Update ctest version The latest ctest version enabled the ABI roundtrip test by default, in which we initialize all types in Rust by default to some random bit-pattern, pass them to C, verify, modify, pass back to Rust, and verify. This catches issues in the call ABI / calling convention. This PR will silence those here for now.
|
💔 Test failed - checks-travis |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Jul 5, 2019
Update ctest version The latest ctest version enabled the ABI roundtrip test by default, in which we initialize all types in Rust by default to some random bit-pattern, pass them to C, verify, modify, pass back to Rust, and verify. This catches issues in the call ABI / calling convention. This PR will silence those here for now.
|
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest ctest version enabled the ABI roundtrip test by default, in which we initialize all types in Rust by default to some random bit-pattern, pass them to C, verify, modify, pass back to Rust, and verify.
This catches issues in the call ABI / calling convention.
This PR will silence those here for now.