Support Vxworks #1408

BaoshanPang · 2019-06-26T08:47:37Z

Define the C interface to VxWorks

rust-highfive · 2019-06-26T08:47:40Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

gnzlbg · 2019-06-26T08:54:02Z

This should at least test that libc builds correctly for this target (e.g. check ci/builds.sh, you might want to add all the vxworks target triples to the "rust nightly" environment variable).

BaoshanPang · 2019-06-26T09:07:50Z

This should at least test that libc builds correctly for this target (e.g. check ci/builds.sh, you might want to add all the vxworks target triples to the "rust nightly" environment variable).

@gnzlbg
I have added all the vxworks target triples but I think they are not going to build pass as they are not supported in rust yet. The PR to support vxWorks in rust is still on going:
rust-lang/rust#61946

gnzlbg · 2019-06-26T09:12:41Z

I have added all the vxworks target triples but I think they are not going to build pass as they are not supported in rust yet

You should probably add the target triples first, then libcore support, then libc, then liballoc, and then libstd support. WIth libcore support, the target triples here would work.

gnzlbg · 2019-06-26T09:13:47Z

Also, is it possible to run VxWorks under KVM or qemu on Linux ? If so, we'll need docker containers for these targets that do just that (e.g. see ci/docker for examples).

gnzlbg · 2019-07-07T13:37:05Z

ping

BaoshanPang · 2019-07-16T02:57:48Z

Also, is it possible to run VxWorks under KVM or qemu on Linux ? If so, we'll need docker containers for these targets that do just that (e.g. see ci/docker for examples).

No, VxWorks can't run under KVM or qemu.

BaoshanPang · 2019-07-16T03:04:17Z

ping

Sorry for the late response.
The PR for rust-lang/rust#61946 has been approved, the code will be upstreamed soon. I will let you know when the code are upstreamed so we can run the build test.
The target triples have been updated so I also need to update the file build.sh

gnzlbg · 2019-07-16T09:48:36Z

Congrats and awesome.

I will let you know when the code are upstreamed so we can run the build test.

Just update this PR with the build tests, and then we can merge it.

BaoshanPang · 2019-07-17T01:21:44Z

Caused by:
process didn't exit successfully: rustc - --crate-name ___ --print=file-names --target armv7-wrs-vxworks --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro (exit code: 1)
--- stderr
error: Error loading target specification: Could not find specification for target "armv7-wrs-vxworks"

I guess the rust version used for testing is not new enough to have the code to support vxWorks targets.
Is it possible to let test use the latest rust code?

gnzlbg · 2019-07-17T05:32:09Z

The version used for testing is the latest nightly version. If the target isn’t there, then no rust version exists with the target.

BaoshanPang · 2019-07-17T06:59:13Z

The version used for testing is the latest nightly version. If the target isn’t there, then no rust version exists with the target.

My code was merged yerterday night some point, I guess these targets will show up with the next build.

gnzlbg · 2019-07-17T07:12:23Z

My code was merged yerterday night some point, I guess these targets will show up with the next build.

Yes that's normal, it might take one day till the next nightly is released. You can locally try to see if your target is there. If it isn't then maybe publishing the rust-src component hasn't been properly set up for the target, and we would need to check what happened.

BaoshanPang · 2019-07-18T01:36:41Z

error: internal compiler error: src/librustc_codegen_llvm/context.rs:192: data-layout for builtin armv7-unknown-linux-gnueabihf target, e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64, differs from LLVM default, e-m:e-p:32:32-Fi8-i64:64-v128:64:128-a:0:32-n32-S64

The PR to fix this issue has been created yesterday, it is waiting to be merged:
rust-lang/rust#62745

BaoshanPang · 2019-07-19T02:02:46Z

Downloaded rand v0.6.5
Downloaded syn v0.15.39
Command exited with code -1073741819

This seems not a problem in my code.

BaoshanPang · 2019-07-19T11:28:13Z

rustup target add armv7-wrs-vxworks --toolchain stable
error: toolchain 'stable-x86_64-unknown-linux-gnu' does not contain component 'rust-std' for target 'armv7-wrs-vxworks'

This is expected result as to build the "rust-std" for target armv7-wrs-vxworks, vxworks's work envionment(the compiler used to build C code, the linker to link libraries and executables etc) has to be installed somethere.

BaoshanPang · 2019-07-23T01:33:19Z

@gnzlbg

Can you give any suggestion what should I do next?

Thanks,
Baoshan

gnzlbg · 2019-07-23T14:11:22Z

ci/build.sh

@@ -93,6 +93,13 @@ x86_64-unknown-freebsd \
 x86_64-unknown-linux-gnu \
 x86_64-unknown-linux-musl \
 x86_64-unknown-netbsd \
+armv7-wrs-vxworks \


These are in the incorrect list of targets. You need to put them in the RUST_NIGHTLY_LINUX_TARGETS variable.

Hi gnzlbg,

I have moved these vxworks targets to RUST_NIGHTLY_LINUX_TARGETS.

Thanks,
Baoshan

gnzlbg · 2019-07-25T07:07:13Z

@BaoshanPang so apparently that didn't work, can you try moving them to RUST_LINUX_NO_CORE_TARGETS ?

BaoshanPang · 2019-07-26T07:21:09Z

Hi gnzlbg,

Can you help to check what's problem? It doesn't look like caused by my code.

LLVM ERROR: invalid symbol redefinition
error: Could not compile core.

Thanks,
Baoshan

gnzlbg · 2019-07-26T07:37:02Z

Can you help to check what's problem? It doesn't look like caused by my code.

This is an LLVM bug introduced with the upgrade to LLVM 9 in rust-lang/rust. There is a tracking issue there (rust-lang/rust#62932) that has been reproduced and now an LLVM bug has been filled (https://bugs.llvm.org/show_bug.cgi?id=42760).

You can try commenting out the thumbv6m-none-eabi target in the build.sh script (adding a FIXME linking to the rust-lang/rust issue).

gnzlbg · 2019-07-26T16:05:05Z

I've disabled the failing build test on master temporarily. Closing and reopening the PR to restart the CI builds.

BaoshanPang · 2019-07-26T16:15:46Z

I've disabled the failing build test on master temporarily. Closing and reopening the PR to restart the CI builds.

Thanks for help.

gnzlbg

Some minor nits, but it looks good. I think we can merge this afterwards.

src/vxworks/mod.rs

gnzlbg · 2019-07-28T16:16:24Z

@bors: r+

bors · 2019-07-28T16:16:26Z

📌 Commit b277cd5 has been approved by gnzlbg

bors · 2019-07-28T16:35:42Z

⌛ Testing commit b277cd5 with merge 94a46ce...

gnzlbg · 2019-08-05T16:34:49Z

Sadly, the repo is in the middle of a transition to Azure Pipelines, and until it is finished nothing can be merged anymore.

BaoshanPang · 2019-08-05T16:42:04Z

Sadly, the repo is in the middle of a transition to Azure Pipelines, and until it is finished nothing can be merged anymore.

Thanks for lettting me know it. Do we have a time when the transition could be done? Thanks.

gnzlbg · 2019-08-06T08:50:10Z

Do we have a time when the transition could be done? Thanks.

I don't think so. As soon as #1376 is merged.

gnzlbg · 2019-08-09T08:19:07Z

@bors: r+

bors · 2019-08-09T08:19:08Z

📌 Commit 5c101cc has been approved by gnzlbg

bors · 2019-08-09T08:19:17Z

⌛ Testing commit 5c101cc with merge a3a2e04...

Support Vxworks Define the C interface to VxWorks

bors · 2019-08-09T09:43:02Z

💔 Test failed - status-azure

src/lib.rs

src/vxworks/mod.rs

…yun-lee

gnzlbg · 2019-08-09T17:35:19Z

@bors: r+

let's merge this!

bors · 2019-08-09T17:35:20Z

📌 Commit 4e3fcdd has been approved by gnzlbg

bors · 2019-08-09T17:35:28Z

⌛ Testing commit 4e3fcdd with merge d81d5c3...

Support Vxworks Define the C interface to VxWorks

bors · 2019-08-09T18:25:01Z

💔 Test failed - status-azure

…owerPC, PowerPC SPE and PowerPC 64-bit.

BaoshanPang · 2019-08-09T20:41:31Z

@gnzlbg
Please help to let bors to retry.

Thanks,
Baoshan

gnzlbg · 2019-08-10T14:09:52Z

@bors: r+

bors · 2019-08-10T14:09:54Z

📌 Commit d18003a has been approved by gnzlbg

bors · 2019-08-10T14:10:01Z

⌛ Testing commit d18003a with merge 9b09188...

Support Vxworks Define the C interface to VxWorks

bors · 2019-08-10T15:20:17Z

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 9b09188 to master...

gnzlbg · 2019-08-12T08:02:05Z

@BaoshanPang thank you for working on this! Sorry that it took so long to merge it!

Does VxWorks provide any kind of emulator to test applications on, e.g., x86 linux ?

BaoshanPang · 2019-08-12T15:05:17Z

@BaoshanPang thank you for working on this! Sorry that it took so long to merge it!

Does VxWorks provide any kind of emulator to test applications on, e.g., x86 linux ?

We are using "simics" to test rust: https://en.wikipedia.org/wiki/Simics

n-salim · 2019-08-14T16:04:29Z

@gnzlbg thanks for your help getting this initial VxWorks support into Rust libc.

Does VxWorks provide any kind of emulator to test applications on, e.g., x86 linux ?

We don't (yet) have a straightforward way for people other than Wind River's VxWorks customers to build and run VxWorks applications (including Rust executables), but this is something we hope to address in future.

We'd certainly like to be able to provide a way for "anyone" to try out Rust under VxWorks. Stay tuned!

gnzlbg · 2019-08-15T04:50:17Z

@n-salim until such a method is available, my recommendation is for Wind River to run libc tests internally at least, and submit PRs that fix them (fill issues if you have questions). That should catch most serious bugs in the implementation of the FFI wrapper.

If you want to get started with that check out the ci/azure.yml or .cirrus.yml script to see how our CI services do it. You don't necessarily need to use Docker containers, but can, e.g., just run TARGET=... ci/run.sh directly just like the OSX or FreeBSD targets do.

n-salim · 2019-08-15T04:58:57Z

@gnzlbg thanks very much for this information. We'll look into running the libc tests on VxWorks.

rust-highfive assigned gnzlbg Jun 26, 2019

gnzlbg reviewed Jul 23, 2019

View reviewed changes

gnzlbg closed this Jul 26, 2019

gnzlbg reopened this Jul 26, 2019

gnzlbg suggested changes Jul 27, 2019

View reviewed changes

src/vxworks/mod.rs Outdated Show resolved Hide resolved

src/vxworks/mod.rs Show resolved Hide resolved

src/vxworks/mod.rs Show resolved Hide resolved

bors added a commit that referenced this pull request Aug 9, 2019

Auto merge of #1408 - BaoshanPang:vxworks, r=gnzlbg

a3a2e04

Support Vxworks Define the C interface to VxWorks

bors mentioned this pull request Aug 9, 2019

Add IP_RECVERR (unix/linux_like/mod.rs) #1444

Merged

gnzlbg suggested changes Aug 9, 2019

View reviewed changes

src/lib.rs Show resolved Hide resolved

src/vxworks/mod.rs Outdated Show resolved Hide resolved

src/vxworks/mod.rs Outdated Show resolved Hide resolved

Added vxworks libc references - worked on by danielmccormick and taeh…

636d86a

…yun-lee

bors added a commit that referenced this pull request Aug 9, 2019

Auto merge of #1408 - BaoshanPang:vxworks, r=gnzlbg

d81d5c3

Support Vxworks Define the C interface to VxWorks

Define the C interface to vxWorks for x86, x86_64, ARM, ARM 64-bit, P…

d18003a

…owerPC, PowerPC SPE and PowerPC 64-bit.

bors added a commit that referenced this pull request Aug 10, 2019

Auto merge of #1408 - BaoshanPang:vxworks, r=gnzlbg

9b09188

Support Vxworks Define the C interface to VxWorks

bors merged commit d18003a into rust-lang:master Aug 10, 2019

bors mentioned this pull request Aug 10, 2019

Fix redox #1450

Closed

Support Vxworks #1408

Support Vxworks #1408

Conversation

BaoshanPang commented Jun 26, 2019

rust-highfive commented Jun 26, 2019

gnzlbg commented Jun 26, 2019

BaoshanPang commented Jun 26, 2019

gnzlbg commented Jun 26, 2019

gnzlbg commented Jun 26, 2019

gnzlbg commented Jul 7, 2019

BaoshanPang commented Jul 16, 2019

BaoshanPang commented Jul 16, 2019 • edited

gnzlbg commented Jul 16, 2019

BaoshanPang commented Jul 17, 2019 • edited

gnzlbg commented Jul 17, 2019 via email

BaoshanPang commented Jul 17, 2019

gnzlbg commented Jul 17, 2019

BaoshanPang commented Jul 18, 2019

BaoshanPang commented Jul 19, 2019

BaoshanPang commented Jul 19, 2019

BaoshanPang commented Jul 23, 2019

gnzlbg Jul 23, 2019

Choose a reason for hiding this comment

BaoshanPang Jul 25, 2019

Choose a reason for hiding this comment

gnzlbg commented Jul 25, 2019

BaoshanPang commented Jul 26, 2019

gnzlbg commented Jul 26, 2019

gnzlbg commented Jul 26, 2019

BaoshanPang commented Jul 26, 2019

gnzlbg left a comment

Choose a reason for hiding this comment

gnzlbg commented Jul 28, 2019

bors commented Jul 28, 2019

bors commented Jul 28, 2019

gnzlbg commented Aug 5, 2019

BaoshanPang commented Aug 5, 2019

gnzlbg commented Aug 6, 2019

gnzlbg commented Aug 9, 2019

bors commented Aug 9, 2019

bors commented Aug 9, 2019

bors commented Aug 9, 2019

gnzlbg commented Aug 9, 2019

bors commented Aug 9, 2019

bors commented Aug 9, 2019

bors commented Aug 9, 2019

BaoshanPang commented Aug 9, 2019

gnzlbg commented Aug 10, 2019

bors commented Aug 10, 2019

bors commented Aug 10, 2019

bors commented Aug 10, 2019

gnzlbg commented Aug 12, 2019

BaoshanPang commented Aug 12, 2019

n-salim commented Aug 14, 2019

gnzlbg commented Aug 15, 2019

n-salim commented Aug 15, 2019

BaoshanPang commented Jul 16, 2019 •

edited

BaoshanPang commented Jul 17, 2019 •

edited