Deprecate fixed width integer type aliases #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gnzlbg: no appropriate reviewer found, use r? to override |
|
Bindgen should never generate these by default. |
|
@bors: r+ |
|
📌 Commit afa3edf has been approved by |
bors
added a commit
that referenced
this pull request
May 29, 2019
Deprecate fixed width integer type aliases cc @emilio - I think it makes sense to ensure that the latest released version of bindgen works properly with this change. That is, that even when asked to use C types from, e.g., `libc::`, it does not use aliases for the fixed-width integer C types (e.g. `libc::int64_t`) but uses Rust primitive types instead (e.g. `u64`). Closes #1304 .
|
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor |
Hywan
added a commit
to Hywan/wasmer
that referenced
this pull request
Jun 12, 2019
Since rust-lang/libc#1379, fixed width integer type aliases are deprecated. Thus, this patch uses Rust types instead of libc aliases.
bors bot
added a commit
to wasmerio/wasmer
that referenced
this pull request
Jun 14, 2019
494: fix(runtime-c-api) Replace deprecated type aliases from libc r=Hywan a=Hywan Since rust-lang/libc#1379, fixed width integer type aliases are deprecated. Thus, this patch uses Rust types instead of libc aliases. Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
pravic
added a commit
to sciter-sdk/rust-sciter
that referenced
this pull request
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @emilio - I think it makes sense to ensure that the latest released version of bindgen works properly with this change. That is, that even when asked to use C types from, e.g.,
libc::, it does not use aliases for the fixed-width integer C types (e.g.libc::int64_t) but uses Rust primitive types instead (e.g.u64).Closes #1304 .