Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getgrgid_r to accept gid_t. #1328

Merged
merged 1 commit into from Apr 29, 2019
Merged

Fix getgrgid_r to accept gid_t. #1328

merged 1 commit into from Apr 29, 2019

Conversation

crlf0710
Copy link
Member

Closes #1320.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 29, 2019

What are the types of gid_t and uid_t on each of the modified architectures?

@crlf0710
Copy link
Member Author

L:\ThirdParty\rust\libc>rg type | rg gid_t
src\wasi.rs:pub type gid_t = u32;
src\fuchsia\mod.rs:pub type gid_t = u32;
src\redox\mod.rs:pub type gid_t = c_int;
src\unix\mod.rs:pub type gid_t = u32;

L:\ThirdParty\rust\libc>rg type | rg uid_t
src\wasi.rs:pub type uid_t = u32;
src\fuchsia\mod.rs:pub type uid_t = u32;
src\redox\mod.rs:pub type uid_t = c_int;
src\unix\mod.rs:pub type uid_t = u32;
src\unix\bsd\freebsdlike\dragonfly\mod.rs:pub type uuid_t = ::uuid;

Consistent!

@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 29, 2019

So this doesn't change any type, only the type alias used right?

@crlf0710
Copy link
Member Author

Yes, i think so.

@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 29, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 29, 2019

📌 Commit 1cf0294 has been approved by gnzlbg

bors added a commit that referenced this pull request Apr 29, 2019
Fix getgrgid_r to accept gid_t.

Closes #1320.
@bors
Copy link
Contributor

bors commented Apr 29, 2019

⌛ Testing commit 1cf0294 with merge e2bf06c...

@bors
Copy link
Contributor

bors commented Apr 29, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing e2bf06c to master...

@bors bors merged commit 1cf0294 into rust-lang:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getgrgid_r should accept gid_t instead of uid_t
4 participants