Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fix asmjs and wasm32 build jobs #1306

Merged
merged 4 commits into from Mar 26, 2019
Merged

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Mar 25, 2019

This doesn't fix the jobs, but at least now libc-test reports no errors, even though they still fail to link.

@rust-highfive
Copy link

@gnzlbg: no appropriate reviewer found, use r? to override

@gnzlbg gnzlbg force-pushed the fix_asmjs branch 3 times, most recently from 5026df5 to e7dc882 Compare March 25, 2019 20:12
@gnzlbg gnzlbg changed the title Fix asmjs and wasm32 build jobs Don't fix asmjs and wasm32 build jobs Mar 25, 2019
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Mar 26, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 26, 2019

📌 Commit 8abce83 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Mar 26, 2019

⌛ Testing commit 8abce83 with merge 600f635...

bors added a commit that referenced this pull request Mar 26, 2019
Don't fix asmjs and wasm32 build jobs

This doesn't fix the jobs, but at least now libc-test reports no errors, even though they still fail to link.
@bors
Copy link
Contributor

bors commented Mar 26, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 600f635 to master...

@bors bors merged commit 8abce83 into rust-lang:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants