Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that more targets build #1296

Merged
merged 3 commits into from Mar 3, 2019
Merged

Check that more targets build #1296

merged 3 commits into from Mar 3, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Mar 3, 2019

No description provided.

@rust-highfive
Copy link

@gnzlbg: no appropriate reviewer found, use r? to override

@bors
Copy link
Contributor

bors commented Mar 3, 2019

☔ The latest upstream changes (presumably #1292) made this pull request unmergeable. Please resolve the merge conflicts.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Mar 3, 2019

cc @humenda I had to fix a couple of bugs in the l4re implementation related to the --features=extra_traits. Now it should build there too, but the l4re types won't implement the classical traits for now (you can just grep for allow(missing_debug_implementations) to find all the issues there).

cc @Susurrus it seems that the extra_traits feature impacted uclibc as well. I don't know if the current CI covers all issues (probably not since there are some targets like arm / aarch64 that are not tested on CI with uclib), but now it should be possible to implement these while still being sure that libc compiles on more targets.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Mar 3, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 3, 2019

📌 Commit 183c51b has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Mar 3, 2019

⌛ Testing commit 183c51b with merge 83d97c2...

bors added a commit that referenced this pull request Mar 3, 2019
Check that more targets build
@bors
Copy link
Contributor

bors commented Mar 3, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 83d97c2 to master...

@bors bors merged commit 183c51b into rust-lang:master Mar 3, 2019
@humenda
Copy link
Contributor

humenda commented Mar 4, 2019 via email

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Mar 4, 2019

Is there anything special I
need to care about when deriving Debug?

As long as the struct is not repr(packed), then no. The only reason Debug cannot be auto-derived is because it contains an array with more than 32 elements, or a type that does not implement debug. Almost all other manual debug implementations show how to handle larger arrays, so be sure to check a couple of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants