Expose the Layout of the failed allocation in CollectionAllocErr::AllocErr #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is sad about the lack of rustfmt. Otherwise LGTM |
…ocErr This a breaking change to a public API. This enables a similar change proposed in `std`: rust-lang/rust#48043 (comment) There is precedent for this in the `hashglobe` crate, which is Firefox’s (pre-hashbrown) fork of `std::collections::HashMap` with stable `try_reserve`. * https://github.com/servo/servo/blob/b3eed5b5bd/components/hashglobe/src/lib.rs#L29-L42 * https://github.com/servo/servo/blob/b3eed5b5bd/components/hashglobe/src/hash_map.rs#L722
|
Ah, the one-character diff :) Fixed. |
|
@bors r+ |
|
📌 Commit c2e26e7 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 12, 2019
Expose the Layout of the failed allocation in CollectionAllocErr::AllocErr This a breaking change to a public API. This enables a similar change proposed in `std`: rust-lang/rust#48043 (comment) There is precedent for this in the `hashglobe` crate, which is Firefox’s (pre-hashbrown) fork of `std::collections::HashMap` with stable `try_reserve`. * https://github.com/servo/servo/blob/b3eed5b5bd/components/hashglobe/src/lib.rs#L29-L42 * https://github.com/servo/servo/blob/b3eed5b5bd/components/hashglobe/src/hash_map.rs#L722
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a breaking change to a public API.
This enables a similar change proposed in
std: rust-lang/rust#48043 (comment)There is precedent for this in the
hashglobecrate, which is Firefox’s (pre-hashbrown) fork ofstd::collections::HashMapwith stabletry_reserve.