Inline non-nightly lowest_set_bit_nonzero #64
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was surprised to see this tiny function show up in my performance profile on its own. The nightly version of this function was already marked `#[inline]`, but the non-nightly version should be inlined too.
|
Oops, nice catch! |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 16, 2019
64: Inline non-nightly lowest_set_bit_nonzero r=Amanieu a=cuviper I was surprised to see this tiny function show up in my performance profile on its own. The nightly version of this function was already marked `#[inline]`, but the non-nightly version should be inlined too. Co-authored-by: Josh Stone <cuviper@gmail.com>
Build failed
|
|
Needs #65 to land first. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 16, 2019
64: Inline non-nightly lowest_set_bit_nonzero r=Amanieu a=cuviper I was surprised to see this tiny function show up in my performance profile on its own. The nightly version of this function was already marked `#[inline]`, but the non-nightly version should be inlined too. Co-authored-by: Josh Stone <cuviper@gmail.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised to see this tiny function show up in my performance
profile on its own. The nightly version of this function was already
marked
#[inline], but the non-nightly version should be inlined too.