Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RawTable with fallible APIs #459

Closed
wants to merge 1 commit into from
Closed

Update RawTable with fallible APIs #459

wants to merge 1 commit into from

Conversation

udoprog
Copy link
Contributor

@udoprog udoprog commented Aug 25, 2023

This introduces additional raw functions which allows for the use of infallible eq and hasher implementations with a passed around context.

See #456 for a detailed motivation.

Note that eq could be impl Fn rather than impl FnMut after this.

I've also not bothered converting methods that I'm not using yet, such as get_many_unchecked_mut since I want to get an idea whether this change would be accepted or not.

Closes #456

@udoprog
Copy link
Contributor Author

udoprog commented Aug 25, 2023

🤔

   = note: /usr/bin/ld: /rust/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-19964a87984cce8a.rlib(std-19964a87984cce8a.std.d3cd61b6198d5d17-cgu.0.rcgu.o): TLS transition from R_X86_64_TLSLD to R_X86_64_TPOFF32 against `_ZN3std9panicking11panic_count17LOCAL_PANIC_COUNT7__getit3VAL17h3ab482653e57521bE.0' at 0x5af in section `.text._ZN3std2rt19lang_start_internal17h8c00664471eb83c4E' failed
          /rust/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-19964a87984cce8a.rlib: error adding symbols: Bad value
          collect2: error: ld returned 1 exit status

@JustForFun88
Copy link
Contributor

Issue rust-lang/rust#115239

@bors
Copy link
Collaborator

bors commented Aug 27, 2023

☔ The latest upstream changes (presumably #451) made this pull request unmergeable. Please resolve the merge conflicts.

@udoprog udoprog mentioned this pull request Aug 27, 2023
Closed
@udoprog
Copy link
Contributor Author

udoprog commented Aug 27, 2023

Closing based on feedback in #456

@udoprog udoprog closed this Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support fallible eq and hasher in raw API
3 participants
@udoprog @JustForFun88 @bors