Fix cargo build with minimal-versions #45
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For serde versions prior to 1.0.25, hashbrown built with serde feature will result in an error:
```
error[E0407]: method `deserialize_in_place` is not a member of trait `Deserialize`
--> src/external_trait_impls/serde.rs:164:9
|
164 | / fn deserialize_in_place<D>(deserializer: D, place: &mut Self) -> Result<(), D::Error>
165 | | where
166 | | D: Deserializer<'de>,
167 | | {
... |
197 | | deserializer.deserialize_seq(SeqInPlaceVisitor(place))
198 | | }
| |_________^ not a member of trait `Deserialize`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0407`.
error: Could not compile `hashbrown`.
```
Change serde version to 1.0.25 explicitly will fix build with `cargo -Z minimal-versions build --features serde`
|
bors r+ |
|
Thanks! |
bors bot
added a commit
that referenced
this pull request
Feb 24, 2019
45: Fix cargo build with minimal-versions r=Amanieu a=sunng87
For serde versions prior to 1.0.25, hashbrown built with serde feature will result in an error:
```
error[E0407]: method `deserialize_in_place` is not a member of trait `Deserialize`
--> src/external_trait_impls/serde.rs:164:9
|
164 | / fn deserialize_in_place<D>(deserializer: D, place: &mut Self) -> Result<(), D::Error>
165 | | where
166 | | D: Deserializer<'de>,
167 | | {
... |
197 | | deserializer.deserialize_seq(SeqInPlaceVisitor(place))
198 | | }
| |_________^ not a member of trait `Deserialize`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0407`.
error: Could not compile `hashbrown`.
```
Change serde version to 1.0.25 explicitly will fix build with `cargo -Z minimal-versions build --features serde`
Co-authored-by: Ning Sun <classicning@gmail.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For serde versions prior to 1.0.25, hashbrown built with serde feature will result in an error:
Change serde version to 1.0.25 explicitly will fix build with
cargo -Z minimal-versions build --features serde