Fix RawTable::allocation_info for empty table #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amanieu
reviewed
Jan 6, 2023
| @@ -531,7 +531,12 @@ impl<T, A: Allocator + Clone> RawTable<T, A> { | |||
| #[inline] | |||
| #[cfg(feature = "raw")] | |||
| pub fn allocation_info(&self) -> (NonNull<u8>, Layout) { | |||
| self.table.allocation_info(Self::TABLE_LAYOUT) | |||
There was a problem hiding this comment.
Can this check be moved into the method in RawTableInner?
There was a problem hiding this comment.
Are you sure? This way we will do branch (albeit trivial) for paths we don't use in normal operation.
At the moment I added assertion to RawTableInner.allocation_info.
There was a problem hiding this comment.
The reason for the split between RawTable and RawTableInner is to reduce the amount of LLVM IR generated and improve compilation times. In release builds, all the RawTableInner methods are inlined into the RawTable methods.
There was a problem hiding this comment.
Got it. Updated the PR.
stepancheg
force-pushed
the
fix-all-info
branch
3 times, most recently
from
95b794d
to
04447e8
Compare
stepancheg
force-pushed
the
fix-all-info
branch
from
04447e8
to
471c5a6
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376