Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Bucket and RawTable methods that are hard to use safely #372

Merged
merged 1 commit into from Nov 9, 2022
Merged

Remove Bucket and RawTable methods that are hard to use safely #372

merged 1 commit into from Nov 9, 2022

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Nov 9, 2022 •
edited

This removes the following methods in favor of better alternatives:

  • RawTable::erase_no_drop => Use RawTable::erase or RawTable::remove instead.
  • Bucket::read => Use RawTable::remove instead.
  • Bucket::drop => Use RawTable::erase instead.
  • Bucket::write => Use Bucket::as_mut instead.

Fixes #364

@Amanieu
Remove Bucket and RawTable that are hard to use safely
3263559 
This removes the following methods in favor of better alternatives:
- `RawTable::erase_no_drop` => Use `RawTable::erase` or
  `RawTable::remove` instead.
- `Bucket::read` => Use `RawTable::remove` instead.
- `Bucket::drop` => Use `RawTable::erase` instead.
- `Bucket::write` => Use `Bucket::as_mut` instead.
@Amanieu
Copy link
Member Author

Amanieu commented Nov 9, 2022

@bors r+

@Amanieu Amanieu closed this Nov 9, 2022
@Amanieu Amanieu reopened this Nov 9, 2022
@Amanieu
Copy link
Member Author

Amanieu commented Nov 9, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 9, 2022

📌 Commit 3263559 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 9, 2022

⌛ Testing commit 3263559 with merge 37071e5...

@bors
Copy link
Collaborator

bors commented Nov 9, 2022

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 37071e5 to master...

@bors bors merged commit 37071e5 into rust-lang:master Nov 9, 2022
@Amanieu Amanieu changed the title Remove Bucket and RawTable that are hard to use safely Remove Bucket and RawTable methods that are hard to use safely Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bucket::drop and Bucket::read need to be used with deprecated RawTable::erase_no_drop
2 participants
@Amanieu @bors