Check that layout size fits in isize in Layout #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This test is awesome:-) Looks like I forgot that our capacity is smaller than buckets number on 12.5% |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Oct 9, 2022
Documentation fix due to latest changes in the crate. Due to merged PR #357, #362 I think that we need to fix docummentation. Fixed broken links in `HashMap::raw_table` and `HashSet::raw_table`, as well as some typos and mistakes elsewhere (especially in `EntryRef::or_insert_with_key`). To fix #349, I removed capacity comparisons in all places (except `drain` and `clear`), however left the phrase "keeps the allocated memory for reuse", because although the `erase` method may not release the capacity, the subsequent `rehash_in_place` function definitely will release all. Close #349.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rust-lang/rust#95295 we need check that Layout
size, when rounded up to the nearest multiple ofalign, must not overflow isize (i.e., the rounded value must be less than or equal toisize::MAX)