Fix double-drop in RawTable::clone_from #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an element from the destination table panics from its `Drop` impl then elements from that table would end up being dropped twice, which is unsound.
|
@bors r+ |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again. |
|
☀️ Test successful - checks-actions |
Amanieu
added a commit
to Amanieu/rust
that referenced
this pull request
Jul 17, 2022
This fixes a double-free in the `clone_from` function if dropping an existing element in the table panics. See rust-lang/hashbrown#348 for more details. The indexmap crate is also updated to use the latest hashbrown version.
cuviper
pushed a commit
to cuviper/rust
that referenced
this pull request
Jul 17, 2022
This fixes a double-free in the `clone_from` function if dropping an existing element in the table panics. See rust-lang/hashbrown#348 for more details.
bjorn3
pushed a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Jul 25, 2022
This fixes a double-free in the `clone_from` function if dropping an existing element in the table panics. See rust-lang/hashbrown#348 for more details.
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 5, 2022
This fixes a double-free in the `clone_from` function if dropping an existing element in the table panics. See rust-lang/hashbrown#348 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an element from the destination table panics from its
Dropimplthen elements from that table would end up being dropped twice, which is
unsound.