Editing do_alloc
for reducing LLVM IR
#341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will speed up compilation, since one way or another everything will come down to this code (but I didn’t compare performance).
I don’t know if the compiler was able to optimize that old code, but it literally checked the same thing twice (due to
map
andmap_err
in a row, and roughly speaking it came down to:And when the code is written explicitly, it is immediately clear that it looks strange. And why force the compiler to think beyond the need?
And finally, in my opinion, the readability of the code has not only not decreased, but even increased.