Issue #297: Implement From<array> on HashSet and HashMap #298
+50
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4LT
changed the title
|
Since we're due for major version bump, could you update the CI and README to point to the latest stable instead of 1.49? |
|
Okay, I've done that, but now builds are failing with Ahh, it depends on the feature |
|
@bors r+ |
|
📌 Commit ba8b56c has been approved by |
|
☀️ Test successful - checks-actions |
Enselic
added a commit
to Enselic/bat
that referenced
this pull request
Aug 12, 2022
This is what `hashbrown` did recently: rust-lang/hashbrown#298 And it causes CI failures for us. Examples: * sharkdp#2266 * sharkdp#2265 The path of least resistance for us is to also bump MSRV, so let's do that. 1.56.1 was released [9 months ago](https://blog.rust-lang.org/2021/11/01/Rust-1.56.1.html).
Enselic
added a commit
to Enselic/bat
that referenced
this pull request
Aug 12, 2022
This is what `hashbrown` did recently: rust-lang/hashbrown#298 And it causes CI failures for us. Examples: * sharkdp#2266 * sharkdp#2265 The path of least resistance for us is to also bump MSRV, so let's do that. 1.56.1 was released [9 months ago](https://blog.rust-lang.org/2021/11/01/Rust-1.56.1.html).
sharkdp
pushed a commit
to sharkdp/bat
that referenced
this pull request
Aug 13, 2022
This is what `hashbrown` did recently: rust-lang/hashbrown#298 And it causes CI failures for us. Examples: * #2266 * #2265 The path of least resistance for us is to also bump MSRV, so let's do that. 1.56.1 was released [9 months ago](https://blog.rust-lang.org/2021/11/01/Rust-1.56.1.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented From<[T; N]> on HashSet and From<[(K, V); N]> on HashMap. In both cases, the default hasher was used to match the implementations from the std crate (see https://doc.rust-lang.org/src/std/collections/hash/map.rs.html#1161-1190)
Edition was updated to 2021 to take advantage of the change in array's
.into_itermethod from iterating over&Tto iterating overT.Hopefully the implementations are trivial enough that tests aren't necessary ;)