Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the bounds on HashSet: Debug #296

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Sep 30, 2021

This looks to be just an oversight.

The bounds on HashMap are similarly loose:

hashbrown/src/map.rs

Lines 1540 to 1545 in 1e1bb23

impl<K, V, S, A> Debug for HashMap<K, V, S, A>
where
K: Debug,
V: Debug,
A: Allocator + Clone,
{

And std::collections::HashSet has always only bounded T by Debug and not Eq/Hash here.

@Amanieu
Copy link
Member

Amanieu commented Oct 2, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 2, 2021

📌 Commit 69e3da9 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Oct 2, 2021

⌛ Testing commit 69e3da9 with merge 612057b...

@bors
Copy link
Contributor

bors commented Oct 2, 2021

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 612057b to master...

@bors bors merged commit 612057b into rust-lang:master Oct 2, 2021
@CAD97 CAD97 deleted the relax-set-debug branch October 2, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants