Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the use of ^ for negation in addition to !? #116

Open
ackerleytng opened this issue Jul 12, 2022 · 1 comment · May be fixed by #141
Open

Allow the use of ^ for negation in addition to !? #116

ackerleytng opened this issue Jul 12, 2022 · 1 comment · May be fixed by #141

Comments

@ackerleytng
Copy link

Would you consider allowing the use of ^ for negation in addition to !?

gnu coreutils supports the use of ^ in addition to !, based on the behavior of ls and du. I tried finding documentation of this in code, and found this in fnmatch.c

Or perhaps, instead of a direct comparison with '!' at https:/github.com/rust-lang/glob/blob/master/src/lib.rs#L614, can we call a method like is_negation_character? That way, this library can be extended.
@ackerleytng ackerleytng mentioned this issue Jul 12, 2022
Closed
@ndmitchell
Copy link

This would also be useful for a project I've been working on, where the incompatibility with Java glob libraries caught us by surprise. I note that @ackerleytng used the workaround of replacing the input string - that would be possible for us too, but it seems like a dangerous thing to do and easy to get wrong.

This was referenced Mar 11, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add caret negation ([^...]) in addition to exclamation mark tertsdiepraam/glob
2 participants
@ndmitchell @ackerleytng