we have to expect non-utf8 strings in tracing messages #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the API here actually take |
|
makes sense. will update that |
|
ok that will break the api though, still ok? I doubt anyone is using that (but me^^) |
|
@alexcrichton in case API breakage is fine then the PR should be good to go |
extrawurst
force-pushed
the
fix-tracing-panic
branch
from
3ddfd37
to
e770d52
Compare
|
If we do not want to break the API we would need a duplication of the API with the changed callback signature. let me know if you want that, then I update the PR |
|
@ehuss maybe you can chime in here? |
|
Hm right yeah that's true, let's keep the lossy string interpretation and this can be updated later during the next major version bump. |
extrawurst
force-pushed
the
fix-tracing-panic
branch
from
e770d52
to
9cdc7af
Compare
added 2 commits
November 29, 2021 22:52
This reverts commit 50a990f. # Conflicts: # src/tracing.rs
|
@alexcrichton done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #769