Make Odb Send and Sync
#763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we can count on new APIs and behavior, whether we're building our vendored version or using a system library.
As of libgit2 1.2.0, `git_odb` uses locking internally, and should be thread-safe. Mark it `Send` and `Sync` to allow access from multiple threads.
joshtriplett
force-pushed
the
odb-sync
branch
from
e192e09
to
25140d6
Compare
|
One day I will get the marker-trait impl syntax right on the first try. But it is not this day. |
|
Also see libgit2/libgit2#6109 |
alexcrichton
approved these changes
Nov 11, 2021
|
@alexcrichton They've now been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of libgit2 1.2.0,
git_odbuses locking internally, and should be thread-safe. Mark itSendandSyncto allow access from multiple threads.