Use cc 1.0.43 or later #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc-1.0.42 should not be used as minimal dependency verison, because it could hang on some environment during the build.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc-1.0.42 should not be used as minimal dependency verison, because it could hang on some environment during the build.
I use
cargo +nightly update -Z minimal-versionson CI to generate Cargo.lock for minimal depnedency versions and check if Cargo.toml is OK.However, I confirmed that compilation using cc 1.0.42 hangs on rust:latest docker (maybe Debian?).
I think this is rust-lang/cc-rs#440, and this version should be avoided.