Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tag_foreach to repo (#594) #595

Merged
merged 2 commits into from Jul 20, 2020
Merged

add tag_foreach to repo (#594) #595

merged 2 commits into from Jul 20, 2020

Conversation

extrawurst
Copy link
Contributor

closes #594

@alexcrichton
Copy link
Member

Thanks! Should this perhaps yield &[u8] instead of Option<&str> to make sure we can yield everything?

@extrawurst
Copy link
Contributor Author

extrawurst commented Jul 20, 2020 •
edited

@alexcrichton good idea! will do that. other than that u r good with it?

@extrawurst
Copy link
Contributor Author

@alexcrichton updated

@alexcrichton
Copy link
Member

Thanks!

@alexcrichton alexcrichton merged commit a3e129e into rust-lang:master Jul 20, 2020
@extrawurst extrawurst deleted the tag-foreach branch July 20, 2020 21:32
@extrawurst
Copy link
Contributor Author

extrawurst commented Jul 20, 2020 •
edited

@alexcrichton thanks a bunch! As usual I would love to have a release to give it a spin in extrawurst/gitui#206 :)

@alexcrichton
Copy link
Member

Sure thing, done now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

safe wrapper for git_tag_foreach
2 participants
@extrawurst @alexcrichton