Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yank versions 0.1.0 to 0.2.16 #110

Open
KamilaBorowska opened this issue Jan 21, 2022 · 0 comments
Open

Yank versions 0.1.0 to 0.2.16 #110

KamilaBorowska opened this issue Jan 21, 2022 · 0 comments

Comments

@KamilaBorowska
Copy link

As of Rust 1.36, those versions don't compile. This was fixed for 0.2.17 by #61. I think it would be useful to yank those versions for cargo update -Z minimal-versions builds (rust-lang/cargo#5657).

For convenience, commands that can be used to yank all those versions.

cargo yank --vers 0.1.0
cargo yank --vers 0.1.1
cargo yank --vers 0.1.2
cargo yank --vers 0.1.3
cargo yank --vers 0.1.4
cargo yank --vers 0.2.0
cargo yank --vers 0.2.1
cargo yank --vers 0.2.2
cargo yank --vers 0.2.3
cargo yank --vers 0.2.4
cargo yank --vers 0.2.5
cargo yank --vers 0.2.6
cargo yank --vers 0.2.7
cargo yank --vers 0.2.8
cargo yank --vers 0.2.9
cargo yank --vers 0.2.10
cargo yank --vers 0.2.11
cargo yank --vers 0.2.12
cargo yank --vers 0.2.13
cargo yank --vers 0.2.14
cargo yank --vers 0.2.15
cargo yank --vers 0.2.16
phimuemue added a commit to phimuemue/hanabi.rs that referenced this issue Jul 3, 2022
The pinned version does not compile anymore because of mutable aliasing:
* rust-lang/getopts#61
* rust-lang/getopts#110

This was achieved by temporarily setting the getopts version to "0.2.21"
in Cargo.toml, and running `cargo check`.

Note that this also converts the Cargo.lock to a new format.
WuTheFWasThat pushed a commit to WuTheFWasThat/hanabi.rs that referenced this issue Jul 5, 2022
* Fix getopts version

The pinned version does not compile anymore because of mutable aliasing:
* rust-lang/getopts#61
* rust-lang/getopts#110

This was achieved by temporarily setting the getopts version to "0.2.21"
in Cargo.toml, and running `cargo check`.

Note that this also converts the Cargo.lock to a new format.

* Fix warning: Instead of deprecated macro try!, use question mark operator

* Fix warning: Avoid anonymous parameters

* Fix warning: Use dyn on trait objects

* Fix warning: Avoid unneeded mutability

* Fix warning: Avoid redundant format in panic or assert

* Fix lint: Avoid redundant field names in initializers

* Fix lint: Avoid redundant clone

* Fix lint: Avoid literal cast

* Fix lint: Collapse if/else where applicable

I left some if/else branches in place, if there was a certain symmetry between the branches.

* Fix lint: Avoid needless borrow

I left some if/else branches in place, if there was a certain symmetry between the branches.

* Fix lint: Use cloned instead of custom closure

* Fix lint: Avoid unneeded trait bound

* Fix lint: Avoid unneeded trait bound (2) avoid redundant clone

* Fix lint: Use &[T] instead of &Vec<T>

* Fix lint: Avoid & on each pattern

* Fix lint: Avoid manual assign

* Fix lint: Use implicit return

* Fix lint: Merge if/else branches with same value

I left one complicated branch in place.

* Fix lint: Use is_empty instead of comparing len against 0

* Fix lint: Use sum instead of fold

* Fix lint: Avoid clone on Copy types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant