Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing ArcWake, re-export std::task::Wake #2828

Closed
ebkalderon opened this issue Feb 23, 2024 · 3 comments
Closed

Consider removing ArcWake, re-export std::task::Wake #2828

ebkalderon opened this issue Feb 23, 2024 · 3 comments

Comments

@ebkalderon
Copy link
Contributor

ebkalderon commented Feb 23, 2024

The futures-task crate currently defines its own ArcWake trait, but according to #2207, the intention was always to replace it with the equivalent std::task::Wake trait as soon as that got stabilized.

However, it seems that std::task::Wake was stabilized in Rust 1.51, and the MSRV of both the futures-task and futures crates currently sit at 1.56, thanks to these three PRs from around March 2023:

As such, I think it should be safe to finally remove futures::task::ArcWake and simply re-export std::task::Wake in its place, possibly renamed ArcWake to maintain backwards compatibility.

Please feel free to correct me and/or close this issue if there's any context I'm missing!

@taiki-e
Copy link
Member

taiki-e commented Feb 23, 2024

Unfortunately they stabilized the API with different default methods, so we can't do this in 0.3. For 0.4 there is a pinned issue mentioning this and an open PR included in the milestone.

@ebkalderon
Copy link
Contributor Author

ebkalderon commented Feb 23, 2024

Ah, that makes sense. Thanks for chiming in, @taiki-e!

EDIT: Found the PR! It seems to be: #2494

@taiki-e
Copy link
Member

taiki-e commented Feb 26, 2024

Closing in favor of existing issue/pr.

@taiki-e taiki-e closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants