[question] is pin-project on SelectAll necessary?

[yshui]

futures-rs/futures-util/src/stream/select_all.rs

Lines 16 to 34 in 8253b78

	pin_project! {
	/// An unbounded set of streams
	///
	/// This "combinator" provides the ability to maintain a set of streams
	/// and drive them all to completion.
	///
	/// Streams are pushed into this set and their realized values are
	/// yielded as they become ready. Streams will only be polled when they
	/// generate notifications. This allows to coordinate a large number of streams.
	///
	/// Note that you can create a ready-made `SelectAll` via the
	/// `select_all` function in the `stream` module, or you can start with an
	/// empty set with the `SelectAll::new` constructor.
	#[must_use = "streams do nothing unless polled"]
	pub struct SelectAll<St> {
	#[pin]
	inner: FuturesUnordered<StreamFuture<St>>,
	}
	}

FuturesUnordered itself is Unpin, did I miss something?

[yshui]

For the same reason, I think SelectAll doesn't need St: Unpin to implement Stream

[taiki-e]

Yeah, I don't think pin projection is needed here. #2431 removed the need for it but forgot to remove it.

For the same reason, I think SelectAll doesn't need St: Unpin to implement Stream

IIRC, it is required by StreamFuture.

[yshui]

it is required by StreamFuture.

Indeed! sorry I missed that 😅