Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FusedStream for all streams in ReadyChunks #2693

Merged
merged 1 commit into from Jan 20, 2023

Conversation

jongiddy
Copy link
Contributor

ReadyChunks fuses the inner stream, so FusedStream can be implemented for all stream types, not just those that initially implement FusedStream.

`ReadyChunks` fuses the inner stream, so `FusedStream` can be
implemented for all stream types, not just those that initially
implement `FusedStream`.
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e added A-stream Area: futures::stream 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Jan 20, 2023
@taiki-e taiki-e merged commit 59c5095 into rust-lang:master Jan 20, 2023
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Jan 30, 2023
taiki-e pushed a commit that referenced this pull request Jan 30, 2023
`ReadyChunks` fuses the inner stream, so `FusedStream` can be
implemented for all stream types, not just those that initially
implement `FusedStream`.
@taiki-e taiki-e mentioned this pull request Jan 30, 2023
taiki-e pushed a commit that referenced this pull request Jan 30, 2023
`ReadyChunks` fuses the inner stream, so `FusedStream` can be
implemented for all stream types, not just those that initially
implement `FusedStream`.
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Feb 2, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [futures](https://rust-lang.github.io/futures-rs) ([source](https://github.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.25` -> `0.3.26` |

---

### Release Notes

<details>
<summary>rust-lang/futures-rs</summary>

### [`v0.3.26`](https://github.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#&#8203;0326---2023-01-30)

[Compare Source](rust-lang/futures-rs@0.3.25...0.3.26)

-   Add `Either::as_pin_mut` and `Either::as_pin_ref` ([#&#8203;2691](rust-lang/futures-rs#2691))
-   Add `Shared::ptr_eq` and `Shared::ptr_hash` ([#&#8203;2691](rust-lang/futures-rs#2691))
-   Implement `FusedStream` for `Buffered` ([#&#8203;2676](rust-lang/futures-rs#2676))
-   Implement `FusedStream` for all streams in `ReadyChunks` ([#&#8203;2693](rust-lang/futures-rs#2693))
-   Fix bug in `FuturesOrdered::push_front` ([#&#8203;2664](rust-lang/futures-rs#2664))
-   Remove `Fut::Output: Clone` bounds from some `Shared` methods ([#&#8203;2662](rust-lang/futures-rs#2662))
-   Remove `T: Debug` bounds from `Debug` implementations of `mpsc` and `oneshot` types ([#&#8203;2666](rust-lang/futures-rs#2666), [#&#8203;2667](rust-lang/futures-rs#2667))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTYuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExOS4yIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1762
Reviewed-by: crapStone <crapstone@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants