Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set to None only if necessary #2683

Merged
merged 1 commit into from Jan 9, 2023
Merged

Set to None only if necessary #2683

merged 1 commit into from Jan 9, 2023

Conversation

EFanZh
Copy link
Contributor

@EFanZh EFanZh commented Jan 9, 2023

Setting this.first to None does not seem necessary if it is already None.

@EFanZh EFanZh requested a review from taiki-e as a code owner January 9, 2023 16:06
taiki-e
taiki-e approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@taiki-e taiki-e added A-stream Area: futures::stream 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Jan 9, 2023
@taiki-e taiki-e merged commit 7e326f6 into rust-lang:master Jan 9, 2023
taiki-e pushed a commit that referenced this pull request Jan 30, 2023
@EFanZh @taiki-e
Set to None only if necessary (#2683)
417435e
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Jan 30, 2023
taiki-e pushed a commit that referenced this pull request Jan 30, 2023
@EFanZh @taiki-e
Set to None only if necessary (#2683)
d8beb28
@EFanZh EFanZh deleted the change-state-only-if-necessary branch February 3, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
0.3-backport: completed A-stream Area: futures::stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EFanZh @taiki-e