remove some double trait bounds #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why the CI failed. |
|
CI failure should be fixed in the latest master (#2644). Could you rebase? |
Signed-off-by: TennyZhuang <zty0826@gmail.com>
TennyZhuang
force-pushed
the
remove-unnecessary-double-trait-bound
branch
from
efe50d5
to
26e430a
Compare
|
rebased |
taiki-e
pushed a commit
that referenced
this pull request
Oct 20, 2022
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Merged
taiki-e
pushed a commit
that referenced
this pull request
Oct 20, 2022
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TennyZhuang zty0826@gmail.com
Make the code clear.
I guess it's better to be a clippy rule, but at least we can make it cleaner manually.