https://github.com/rust-lang/futures-rs/pull/2583 introduced regression in select_with_strategy

[Sushisource]

Hello,

Recently updated my deps and started encountering all sorts of weird errors.

Narrowed it down to likely being something with select_with_strategy, and looking at the change notes I suspect this line of code here is the source of my problems.

I am (as in the example here) using an always-select-left strategy. The problem with the new code is that, if the right stream terminates, such a strategy now considers the combined stream as terminated.

I have created a PR here for the fix , but have not had time to add a test quite yet. There should definitely be one though, clearly.

[taiki-e]

cc @414owen

[414owen]

@Sushisource It's quite possible that I've introduced a regression, but I don't it think would be in the lines you linked.

I've commented on your PR with more detail.