Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stacked borrows violations with -Zmiri-tag-raw-pointers in waker_ref and FuturesUnordered #2550

Merged
merged 1 commit into from Jan 12, 2022
Merged

Fix stacked borrows violations with -Zmiri-tag-raw-pointers in waker_ref and FuturesUnordered #2550

merged 1 commit into from Jan 12, 2022

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 12, 2022 •
edited

Split from #2548

To fix this problem, we need to use Arc::as_ptr. Therefore, this increases the MSRV of futures-task to 1.45.

See rust-lang/rust#67339 for more.

waker_ref:

MIRIFLAGS="-Zmiri-disable-isolation -Zmiri-tag-raw-pointers" cargo miri test -p futures-channel --test mpsc-close -- smoke
output 
error: Undefined Behavior: trying to reborrow for SharedReadWrite at alloc366730, but parent tag <985917> does not have an appropriate item in the borrow stack
   --> /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ptr/non_null.rs:327:18
    |
327 |         unsafe { &*self.as_ptr() }
    |                  ^^^^^^^^^^^^^^^ trying to reborrow for SharedReadWrite at alloc366730, but parent tag <985917> does not have an appropriate item in the borrow stack
    |
    = help: this indicates a potential bug in the program: it performed an invalid operation, but the rules it violated are still experimental
    = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information
            
    = note: inside `std::ptr::NonNull::<alloc::sync::ArcInner<futures::futures_executor::local_pool::ThreadNotify>>::as_ref` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ptr/non_null.rs:327:18
    = note: inside `std::sync::Arc::<futures::futures_executor::local_pool::ThreadNotify>::inner` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/alloc/src/sync.rs:1071:18
    = note: inside `<std::sync::Arc<futures::futures_executor::local_pool::ThreadNotify> as std::clone::Clone>::clone` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/alloc/src/sync.rs:1329:24
    = note: inside `<std::mem::ManuallyDrop<std::sync::Arc<futures::futures_executor::local_pool::ThreadNotify>> as std::clone::Clone>::clone` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/mem/manually_drop.rs:50:5
    = note: inside `futures_task::waker::increase_refcount::<futures::futures_executor::local_pool::ThreadNotify>` at /Users/taiki/projects/futures-rs/futures-task/src/waker.rs:36:44
    = note: inside `futures_task::waker::clone_arc_raw::<futures::futures_executor::local_pool::ThreadNotify>` at /Users/taiki/projects/futures-rs/futures-task/src/waker.rs:41:5
    = note: inside `<std::task::Waker as std::clone::Clone>::clone` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/task/wake.rs:273:29
    = note: inside `futures::task::AtomicWaker::register` at /Users/taiki/projects/futures-rs/futures-core/src/task/__internal/atomic_waker.rs:267:46
    = note: inside `<futures::futures_channel::mpsc::Receiver<i32> as futures::Stream>::poll_next` at /Users/taiki/projects/futures-rs/futures-channel/src/mpsc/mod.rs:1070:17
    = note: inside `<futures::stream::Take<futures::futures_channel::mpsc::Receiver<i32>> as futures::Stream>::poll_next` at /Users/taiki/projects/futures-rs/futures-util/src/stream/stream/take.rs:40:31
    = note: inside `<futures::stream::ForEach<futures::stream::Take<futures::futures_channel::mpsc::Receiver<i32>>, futures::future::Ready<()>, [closure@futures-channel/tests/mpsc-close.rs:19:40: 19:70]> as futures::Future>::poll` at /Users/taiki/projects/futures-rs/futures-util/src/stream/stream/for_each.rs:70:47
    = note: inside closure at /Users/taiki/projects/futures-rs/futures-executor/src/local_pool.rs:315:23
    = note: inside closure at /Users/taiki/projects/futures-rs/futures-executor/src/local_pool.rs:90:37
    = note: inside `std::thread::LocalKey::<std::sync::Arc<futures::futures_executor::local_pool::ThreadNotify>>::try_with::<[closure@futures::futures_executor::local_pool::run_executor<(), [closure@futures::futures_executor::block_on<futures::stream::ForEach<futures::stream::Take<futures::futures_channel::mpsc::Receiver<i32>>, futures::future::Ready<()>, [closure@futures-channel/tests/mpsc-close.rs:19:40: 19:70]>>::{closure#0}]>::{closure#0}], ()>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:412:16
    = note: inside `std::thread::LocalKey::<std::sync::Arc<futures::futures_executor::local_pool::ThreadNotify>>::with::<[closure@futures::futures_executor::local_pool::run_executor<(), [closure@futures::futures_executor::block_on<futures::stream::ForEach<futures::stream::Take<futures::futures_channel::mpsc::Receiver<i32>>, futures::future::Ready<()>, [closure@futures-channel/tests/mpsc-close.rs:19:40: 19:70]>>::{closure#0}]>::{closure#0}], ()>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:388:9
    = note: inside `futures::futures_executor::local_pool::run_executor::<(), [closure@futures::futures_executor::block_on<futures::stream::ForEach<futures::stream::Take<futures::futures_channel::mpsc::Receiver<i32>>, futures::future::Ready<()>, [closure@futures-channel/tests/mpsc-close.rs:19:40: 19:70]>>::{closure#0}]>` at /Users/taiki/projects/futures-rs/futures-executor/src/local_pool.rs:86:5
    = note: inside `futures::futures_executor::block_on::<futures::stream::ForEach<futures::stream::Take<futures::futures_channel::mpsc::Receiver<i32>>, futures::future::Ready<()>, [closure@futures-channel/tests/mpsc-close.rs:19:40: 19:70]>>` at /Users/taiki/projects/futures-rs/futures-executor/src/local_pool.rs:315:5
note: inside `smoke` at futures-channel/tests/mpsc-close.rs:19:5
   --> futures-channel/tests/mpsc-close.rs:19:5
    |
19  |     block_on(receiver.take(3).for_each(|_| futures::future::ready(())));
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside closure at futures-channel/tests/mpsc-close.rs:13:1
   --> futures-channel/tests/mpsc-close.rs:13:1
    |
12  |   #[test]
    |   ------- in this procedural macro expansion
13  | / fn smoke() {
14  | |     let (mut sender, receiver) = mpsc::channel(1);
15  | |
16  | |     let t = thread::spawn(move || while let Ok(()) = block_on(sender.send(42)) {});
...   |
21  | |     t.join().unwrap()
22  | | }
    | |_^
    = note: inside `<[closure@futures-channel/tests/mpsc-close.rs:13:1: 22:2] as std::ops::FnOnce<()>>::call_once - shim` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
    = note: inside `<fn() as std::ops::FnOnce<()>>::call_once - shim(fn())` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
    = note: inside `test::__rust_begin_short_backtrace::<fn()>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:574:5
    = note: inside closure at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:565:30
    = note: inside `<[closure@test::run_test::{closure#1}] as std::ops::FnOnce<()>>::call_once - shim(vtable)` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
    = note: inside `<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send> as std::ops::FnOnce<()>>::call_once` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/alloc/src/boxed.rs:1854:9
    = note: inside `<std::panic::AssertUnwindSafe<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>> as std::ops::FnOnce<()>>::call_once` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/panic/unwind_safe.rs:271:9
    = note: inside `std::panicking::r#try::do_call::<std::panic::AssertUnwindSafe<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>>, ()>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:406:40
    = note: inside `std::panicking::r#try::<(), std::panic::AssertUnwindSafe<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>>>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:370:19
    = note: inside `std::panic::catch_unwind::<std::panic::AssertUnwindSafe<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>>, ()>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panic.rs:133:14
    = note: inside `test::run_test_in_process` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:597:18
    = note: inside closure at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:491:39
    = note: inside `test::run_test::run_test_inner` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:529:13
    = note: inside `test::run_test` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:561:28
    = note: inside `test::run_tests::<[closure@test::run_tests_console::{closure#2}]>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:304:17
    = note: inside `test::run_tests_console` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/console.rs:290:5
    = note: inside `test::test_main` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:115:15
    = note: inside `test::test_main_static` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:134:5
    = note: inside `main`
    = note: inside `<fn() as std::ops::FnOnce<()>>::call_once - shim(fn())` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
    = note: inside `std::sys_common::backtrace::__rust_begin_short_backtrace::<fn(), ()>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/sys_common/backtrace.rs:123:18
    = note: inside closure at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/rt.rs:145:18
    = note: inside `std::ops::function::impls::<impl std::ops::FnOnce<()> for &dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe>::call_once` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:259:13
    = note: inside `std::panicking::r#try::do_call::<&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe, i32>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:406:40
    = note: inside `std::panicking::r#try::<i32, &dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:370:19
    = note: inside `std::panic::catch_unwind::<&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe, i32>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panic.rs:133:14
    = note: inside closure at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/rt.rs:128:48
    = note: inside `std::panicking::r#try::do_call::<[closure@std::rt::lang_start_internal::{closure#2}], isize>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:406:40
    = note: inside `std::panicking::r#try::<isize, [closure@std::rt::lang_start_internal::{closure#2}]>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:370:19
    = note: inside `std::panic::catch_unwind::<[closure@std::rt::lang_start_internal::{closure#2}], isize>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panic.rs:133:14
    = note: inside `std::rt::lang_start_internal` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/rt.rs:128:20
    = note: inside `std::rt::lang_start::<()>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/rt.rs:144:17
    = note: this error originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)

FuturesUnordered:

MIRIFLAGS="-Zmiri-disable-isolation -Zmiri-tag-raw-pointers" cargo miri test -p futures:0.4.0-alpha.0 --test stream_futures_ordered -- works_1
output 
error: Undefined Behavior: trying to reborrow for SharedReadWrite at alloc361699, but parent tag <920858> does not have an appropriate item in the borrow stack
   --> /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ptr/non_null.rs:327:18
    |
327 |         unsafe { &*self.as_ptr() }
    |                  ^^^^^^^^^^^^^^^ trying to reborrow for SharedReadWrite at alloc361699, but parent tag <920858> does not have an appropriate item in the borrow stack
    |
    = help: this indicates a potential bug in the program: it performed an invalid operation, but the rules it violated are still experimental
    = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information
            
    = note: inside `std::ptr::NonNull::<alloc::sync::ArcInner<futures::stream::futures_unordered::task::Task<futures::stream::futures_ordered::OrderWrapper<futures::futures_channel::oneshot::Receiver<i32>>>>>::as_ref` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ptr/non_null.rs:327:18
    = note: inside `std::sync::Arc::<futures::stream::futures_unordered::task::Task<futures::stream::futures_ordered::OrderWrapper<futures::futures_channel::oneshot::Receiver<i32>>>>::inner` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/alloc/src/sync.rs:1071:18
    = note: inside `<std::sync::Arc<futures::stream::futures_unordered::task::Task<futures::stream::futures_ordered::OrderWrapper<futures::futures_channel::oneshot::Receiver<i32>>>> as std::ops::Deref>::deref` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/alloc/src/sync.rs:1354:10
    = note: inside `futures::stream::FuturesUnordered::<futures::stream::futures_ordered::OrderWrapper<futures::futures_channel::oneshot::Receiver<i32>>>::unlink` at /Users/taiki/projects/futures-rs/futures-util/src/stream/futures_unordered/mod.rs:356:20
    = note: inside `<futures::stream::FuturesUnordered<futures::stream::futures_ordered::OrderWrapper<futures::futures_channel::oneshot::Receiver<i32>>> as futures::Stream>::poll_next` at /Users/taiki/projects/futures-rs/futures-util/src/stream/futures_unordered/mod.rs:481:33
    = note: inside `<futures::stream::FuturesUnordered<futures::stream::futures_ordered::OrderWrapper<futures::futures_channel::oneshot::Receiver<i32>>> as futures::StreamExt>::poll_next_unpin` at /Users/taiki/projects/futures-rs/futures-util/src/stream/stream/mod.rs:1668:9
    = note: inside `<futures::stream::FuturesOrdered<futures::futures_channel::oneshot::Receiver<i32>> as futures::Stream>::poll_next` at /Users/taiki/projects/futures-rs/futures-util/src/stream/futures_ordered.rs:166:26
    = note: inside `<futures::stream::FuturesOrdered<futures::futures_channel::oneshot::Receiver<i32>> as futures::StreamExt>::poll_next_unpin` at /Users/taiki/projects/futures-rs/futures-util/src/stream/stream/mod.rs:1668:9
    = note: inside `<futures::stream::Next<futures::stream::FuturesOrdered<futures::futures_channel::oneshot::Receiver<i32>>> as futures::Future>::poll` at /Users/taiki/projects/futures-rs/futures-util/src/stream/stream/next.rs:32:9
    = note: inside closure at /Users/taiki/projects/futures-rs/futures-executor/src/local_pool.rs:175:30
    = note: inside closure at /Users/taiki/projects/futures-rs/futures-executor/src/local_pool.rs:90:37
    = note: inside `std::thread::LocalKey::<std::sync::Arc<futures::futures_executor::local_pool::ThreadNotify>>::try_with::<[closure@futures::futures_executor::local_pool::run_executor<std::option::Option<std::result::Result<i32, futures::futures_channel::oneshot::Canceled>>, [closure@futures::futures_executor::LocalPool::run_until<futures::stream::Next<futures::stream::FuturesOrdered<futures::futures_channel::oneshot::Receiver<i32>>>>::{closure#0}]>::{closure#0}], std::option::Option<std::result::Result<i32, futures::futures_channel::oneshot::Canceled>>>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:412:16
    = note: inside `std::thread::LocalKey::<std::sync::Arc<futures::futures_executor::local_pool::ThreadNotify>>::with::<[closure@futures::futures_executor::local_pool::run_executor<std::option::Option<std::result::Result<i32, futures::futures_channel::oneshot::Canceled>>, [closure@futures::futures_executor::LocalPool::run_until<futures::stream::Next<futures::stream::FuturesOrdered<futures::futures_channel::oneshot::Receiver<i32>>>>::{closure#0}]>::{closure#0}], std::option::Option<std::result::Result<i32, futures::futures_channel::oneshot::Canceled>>>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:388:9
    = note: inside `futures::futures_executor::local_pool::run_executor::<std::option::Option<std::result::Result<i32, futures::futures_channel::oneshot::Canceled>>, [closure@futures::futures_executor::LocalPool::run_until<futures::stream::Next<futures::stream::FuturesOrdered<futures::futures_channel::oneshot::Receiver<i32>>>>::{closure#0}]>` at /Users/taiki/projects/futures-rs/futures-executor/src/local_pool.rs:86:5
    = note: inside `futures::futures_executor::LocalPool::run_until::<futures::stream::Next<futures::stream::FuturesOrdered<futures::futures_channel::oneshot::Receiver<i32>>>>` at /Users/taiki/projects/futures-rs/futures-executor/src/local_pool.rs:172:9
    = note: inside `<futures::futures_executor::BlockingStream<futures::stream::FuturesOrdered<futures::futures_channel::oneshot::Receiver<i32>>> as std::iter::Iterator>::next` at /Users/taiki/projects/futures-rs/futures-executor/src/local_pool.rs:356:9
note: inside `works_1` at futures/tests/stream_futures_ordered.rs:23:30
   --> futures/tests/stream_futures_ordered.rs:23:30
    |
23  |     assert_eq!(Some(Ok(33)), iter.next());
    |                              ^^^^^^^^^^^
note: inside closure at futures/tests/stream_futures_ordered.rs:9:1
   --> futures/tests/stream_futures_ordered.rs:9:1
    |
8   |   #[test]
    |   ------- in this procedural macro expansion
9   | / fn works_1() {
10  | |     let (a_tx, a_rx) = oneshot::channel::<i32>();
11  | |     let (b_tx, b_rx) = oneshot::channel::<i32>();
12  | |     let (c_tx, c_rx) = oneshot::channel::<i32>();
...   |
26  | |     assert_eq!(None, iter.next());
27  | | }
    | |_^
    = note: inside `<[closure@futures/tests/stream_futures_ordered.rs:9:1: 27:2] as std::ops::FnOnce<()>>::call_once - shim` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
    = note: inside `<fn() as std::ops::FnOnce<()>>::call_once - shim(fn())` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
    = note: inside `test::__rust_begin_short_backtrace::<fn()>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:574:5
    = note: inside closure at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:565:30
    = note: inside `<[closure@test::run_test::{closure#1}] as std::ops::FnOnce<()>>::call_once - shim(vtable)` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
    = note: inside `<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send> as std::ops::FnOnce<()>>::call_once` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/alloc/src/boxed.rs:1854:9
    = note: inside `<std::panic::AssertUnwindSafe<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>> as std::ops::FnOnce<()>>::call_once` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/panic/unwind_safe.rs:271:9
    = note: inside `std::panicking::r#try::do_call::<std::panic::AssertUnwindSafe<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>>, ()>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:406:40
    = note: inside `std::panicking::r#try::<(), std::panic::AssertUnwindSafe<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>>>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:370:19
    = note: inside `std::panic::catch_unwind::<std::panic::AssertUnwindSafe<std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>>, ()>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panic.rs:133:14
    = note: inside `test::run_test_in_process` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:597:18
    = note: inside closure at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:491:39
    = note: inside `test::run_test::run_test_inner` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:529:13
    = note: inside `test::run_test` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:561:28
    = note: inside `test::run_tests::<[closure@test::run_tests_console::{closure#2}]>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:304:17
    = note: inside `test::run_tests_console` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/console.rs:290:5
    = note: inside `test::test_main` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:115:15
    = note: inside `test::test_main_static` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/test/src/lib.rs:134:5
    = note: inside `main`
    = note: inside `<fn() as std::ops::FnOnce<()>>::call_once - shim(fn())` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
    = note: inside `std::sys_common::backtrace::__rust_begin_short_backtrace::<fn(), ()>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/sys_common/backtrace.rs:123:18
    = note: inside closure at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/rt.rs:145:18
    = note: inside `std::ops::function::impls::<impl std::ops::FnOnce<()> for &dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe>::call_once` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:259:13
    = note: inside `std::panicking::r#try::do_call::<&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe, i32>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:406:40
    = note: inside `std::panicking::r#try::<i32, &dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:370:19
    = note: inside `std::panic::catch_unwind::<&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe, i32>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panic.rs:133:14
    = note: inside closure at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/rt.rs:128:48
    = note: inside `std::panicking::r#try::do_call::<[closure@std::rt::lang_start_internal::{closure#2}], isize>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:406:40
    = note: inside `std::panicking::r#try::<isize, [closure@std::rt::lang_start_internal::{closure#2}]>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:370:19
    = note: inside `std::panic::catch_unwind::<[closure@std::rt::lang_start_internal::{closure#2}], isize>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panic.rs:133:14
    = note: inside `std::rt::lang_start_internal` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/rt.rs:128:20
    = note: inside `std::rt::lang_start::<()>` at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/rt.rs:144:17
    = note: this error originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)

@taiki-e taiki-e added A-stream Area: futures::stream A-task Area: futures::task 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Jan 12, 2022
@taiki-e taiki-e merged commit 5d11c08 into master Jan 12, 2022
@taiki-e taiki-e deleted the taiki-e/arc-as-ptr branch January 12, 2022 20:06
@taiki-e taiki-e changed the title Fix stacked borrows violations in waker_ref and FuturesUnordered Fix stacked borrows violations with -Zmiri-tag-raw-pointers in waker_ref and FuturesUnordered Jan 22, 2022
@taiki-e taiki-e mentioned this pull request Jan 28, 2022
Merged
taiki-e added a commit that referenced this pull request Feb 6, 2022
@taiki-e
Fix stacked borrows violations in waker_ref and FuturesUnordered (#2550)
66d7688
@taiki-e taiki-e mentioned this pull request Feb 6, 2022
Merged
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Feb 6, 2022
taiki-e added a commit that referenced this pull request Feb 6, 2022
@taiki-e
Fix stacked borrows violations in waker_ref and FuturesUnordered (#2550)
b297565
@taiki-e taiki-e mentioned this pull request Feb 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.3-backport: completed A-stream Area: futures::stream A-task Area: futures::task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@taiki-e