Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unstable read-initializer feature #2534

Merged
merged 2 commits into from Dec 18, 2021
Merged

Remove unstable read-initializer feature #2534

merged 2 commits into from Dec 18, 2021

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Dec 18, 2021

Closes #2532

@taiki-e taiki-e added A-io Area: futures::io 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Dec 18, 2021
@taiki-e
Fix clippy::return_self_not_must_use warning
8df0fc3 
```text
error: missing `#[must_use]` attribute on a method returning `Self`
  --> futures-util/src/stream/select_with_strategy.rs:19:5
   |
19 | /     pub fn toggle(&mut self) -> Self {
20 | |         let old = *self;
21 | |
22 | |         match self {
...  |
27 | |         old
28 | |     }
   | |_____^
   |
```
@taiki-e taiki-e merged commit 6edf1a7 into master Dec 18, 2021
@taiki-e taiki-e deleted the taiki-e/read-initializer branch December 18, 2021 14:09
@taiki-e taiki-e changed the title Remove read-initializer feature Remove unstable read-initializer feature Dec 18, 2021
This was referenced Dec 18, 2021
Merged
Merged
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.3-backport: completed A-io Area: futures::io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unstable read-initializer feature
1 participant
@taiki-e