Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose iterators from SelectAll #2428

Merged
merged 8 commits into from May 10, 2021
Merged

expose iterators from SelectAll #2428

merged 8 commits into from May 10, 2021

Conversation

ibraheemdev
Copy link
Member

@ibraheemdev ibraheemdev commented May 9, 2021 •
edited by taiki-e

Closes #1964

@ibraheemdev ibraheemdev requested a review from taiki-e as a code owner May 9, 2021 23:54
@taiki-e taiki-e added A-stream Area: futures::stream 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels May 10, 2021
@taiki-e
Copy link
Member

taiki-e commented May 10, 2021

#2423 merged. Could you also expose other iterators?

@ibraheemdev
Copy link
Member Author

Done.

taiki-e
taiki-e approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 17428de into rust-lang:master May 10, 2021
@taiki-e taiki-e mentioned this pull request May 10, 2021
Merged
taiki-e pushed a commit that referenced this pull request May 10, 2021
@ibraheemdev @taiki-e
expose iterators from SelectAll (#2428)
838570c
@taiki-e taiki-e mentioned this pull request May 10, 2021
Merged
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels May 10, 2021
taiki-e pushed a commit that referenced this pull request May 10, 2021
@ibraheemdev @taiki-e
expose iterators from SelectAll (#2428)
d663bc1
@taiki-e taiki-e mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
0.3-backport: completed A-stream Area: futures::stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose .iter_mut() from SelectAll
2 participants
@ibraheemdev @taiki-e