Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FuturesUnordered::clear #2415

Merged
merged 8 commits into from May 10, 2021
Merged

FuturesUnordered::clear #2415

merged 8 commits into from May 10, 2021

Conversation

ibraheemdev
Copy link
Member

@ibraheemdev ibraheemdev commented May 7, 2021 •
edited

resolves #2327

@ibraheemdev ibraheemdev requested a review from taiki-e as a code owner May 7, 2021 01:43
taiki-e
taiki-e reviewed May 7, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

futures-util/src/stream/futures_unordered/mod.rs Outdated Show resolved Hide resolved
futures/tests/stream_futures_unordered.rs Show resolved Hide resolved
@taiki-e taiki-e added A-stream Area: futures::stream 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels May 7, 2021
taiki-e
taiki-e reviewed May 10, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you resolve the merge conflicts?

@ibraheemdev
Copy link
Member Author

ibraheemdev commented May 10, 2021 •
edited

Resolved.

taiki-e
taiki-e approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 0c4d6a3 into rust-lang:master May 10, 2021
@erickt erickt mentioned this pull request May 10, 2021
Closed
taiki-e pushed a commit that referenced this pull request May 10, 2021
@ibraheemdev @taiki-e
Add FuturesUnordered::clear (#2415)
0924ecb
@taiki-e taiki-e mentioned this pull request May 10, 2021
Merged
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels May 10, 2021
taiki-e pushed a commit that referenced this pull request May 10, 2021
@ibraheemdev @taiki-e
Add FuturesUnordered::clear (#2415)
5912e2e
@taiki-e taiki-e mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
0.3-backport: completed A-stream Area: futures::stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding FuturesUnordered::clear() and SelectAll::clear()
2 participants
@ibraheemdev @taiki-e