Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing proc_macro_hack #2406

Closed
Ciantic opened this issue May 2, 2021 · 2 comments · Fixed by #2407
Closed

Removing proc_macro_hack #2406

Ciantic opened this issue May 2, 2021 · 2 comments · Fixed by #2407
Labels
A-macro Area: macro related

Comments

@Ciantic
Copy link

Ciantic commented May 2, 2021

The macros using proc_macro_hack like select!, try_join! don't work with Rust Analyzer ( rust-lang/rust-analyzer#6835 ).

I don't know what is required to remove proc_macro_hack, but given that it's page says:

Note: As of Rust 1.45 this crate is superseded by native support for #[proc_macro] in expression position. Only consider using this crate if you care about supporting compilers between 1.31 and 1.45.

It could be replaceable with proc_macro, which has better support.

@taiki-e
Copy link
Member

taiki-e commented May 5, 2021

we can't remove proc_macro_hack as we need to support old compilers but can use #[proc_macro] at Rust 1.45+

@taiki-e
Copy link
Member

taiki-e commented May 11, 2021

Released in 0.3.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-macro Area: macro related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants