Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clone to WeakShared #2396

Merged
merged 1 commit into from Apr 17, 2021
Merged

Add Clone to WeakShared #2396

merged 1 commit into from Apr 17, 2021

Conversation

hlb8122
Copy link
Contributor

@hlb8122 hlb8122 commented Apr 17, 2021

Closes #2395

@hlb8122 hlb8122 requested a review from taiki-e as a code owner April 17, 2021 13:14
taiki-e
taiki-e approved these changes Apr 17, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@taiki-e taiki-e added 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. A-future Area: futures::future labels Apr 17, 2021
@taiki-e taiki-e merged commit c77cd3c into rust-lang:master Apr 17, 2021
@hlb8122 hlb8122 deleted the add-weak-shared-clone branch April 17, 2021 14:26
@taiki-e taiki-e mentioned this pull request Apr 23, 2021
Merged
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Apr 23, 2021
@taiki-e taiki-e mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
0.3-backport: completed A-future Area: futures::future
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WeakShared is not Clone
2 participants
@hlb8122 @taiki-e