Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid once_cell in static wakers #2332

Merged
merged 2 commits into from Feb 6, 2021
Merged

Avoid once_cell in static wakers #2332

merged 2 commits into from Feb 6, 2021

Conversation

SabrinaJewson
Copy link
Contributor

Wakers are #[repr(transparent)] over their inner RawWakers. Therefore, instead of using a once_cell to lazily initialize a Waker with Waker::from_raw, we can instead simply store a static RawWaker and then use pointer casts to obtain a Waker. This also removes the once_cell dependency.

taiki-e
taiki-e approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@taiki-e taiki-e merged commit ddbf522 into rust-lang:master Feb 6, 2021
@taiki-e taiki-e added the A-task Area: futures::task label Feb 6, 2021
@taiki-e taiki-e mentioned this pull request Feb 20, 2021
Merged
This was referenced Mar 12, 2021
Closed
Closed
Closed
exrook pushed a commit to exrook/futures-rs that referenced this pull request Apr 5, 2021
Avoid once_cell in static wakers (rust-lang#2332)
35b9cce
@kpreid kpreid mentioned this pull request Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
A-task Area: futures::task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SabrinaJewson @taiki-e