Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

futures-test: Implement more traits for AssertUnmoved and InterleavePending #2208

Merged
merged 3 commits into from Sep 8, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Sep 5, 2020

Implements the following traits for AssertUnmoved:

  • FusedFuture
  • Stream
  • FusedStream
  • Sink
  • AsyncRead
  • AsyncWrite
  • AsyncSeek
  • AsyncBufRead

Implements the following traits for InterleavePending:

  • Sink
  • AsyncSeek

And adds the following methods:

  • StreamTestExt::assert_unmoved
  • SinkTestExt::assert_unmoved_sink
  • AsyncReadTestExt::assert_unmoved
  • AsyncWriteTestExt::assert_unmoved_write
  • SinkTestExt::interleave_pending_sink

Implements the following traits for AssertUnmoved:
* FusedFuture
* Stream
* FusedStream
* Sink
* AsyncRead
* AsyncWrite
* AsyncSeek
* AsyncBufRead

And adds the following methods:
* StreamTestExt::assert_unmoved
* SinkTestExt::assert_unmoved_sink
* AsyncReadTestExt::assert_unmoved
* AsyncWriteTestExt::assert_unmoved_write
Implements the following traits for InterleavePending:
* Sink
* AsyncSeek

And adds the following methods:
* SinkTestExt::interleave_pending_sink
@taiki-e taiki-e requested a review from Nemo157 September 5, 2020 10:21
Copy link
Member

@Nemo157 Nemo157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😁

@taiki-e taiki-e merged commit 32d970e into rust-lang:master Sep 8, 2020
@taiki-e taiki-e deleted the futures-test branch September 8, 2020 12:43
@taiki-e taiki-e mentioned this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants