Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.2 should be 0.4.0 #2115

Closed
jsancio opened this issue Apr 4, 2020 · 2 comments
Closed

Release 0.3.2 should be 0.4.0 #2115

jsancio opened this issue Apr 4, 2020 · 2 comments

Comments

@jsancio
Copy link

jsancio commented Apr 4, 2020

I believe that when PR #2049 was merged and release it should be consider a breaking change since it changed the semantic of FutureUnordered::poll_next.

This is cargo's version semantic:

This compatibility convention is different from SemVer in the way it treats versions before 1.0.0. While SemVer says there is no compatibility before 1.0.0, Cargo considers 0.x.y to be compatible with 0.x.z, where y ≥ z and x > 0.

I think this means that release 0.3.2 should have really been versioned as 0.4.0.

It is probably already too late to do anything.

@jonhoo
Copy link
Contributor

jonhoo commented Apr 4, 2020

I don't think it is a breaking change, since FuturesUnordered still follows the contract of Future::poll. Does my answer in #2049 (comment) help, or is there some other breakage you are thinking of?

@jsancio
Copy link
Author

jsancio commented Apr 6, 2020

Agree, not a breaking change based on the comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants