You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation of StreamExt::forward should actually be in TryStreamExt as try_forward, I think, because it requires a fallible stream. StreamExt should then provide a forward method that does not require the sink to produce Results.
In other words the fix that merged in #1946 doesn't much sense to me. The code that was there prior to #1946 should be resurrected as StreamExt::forward, as the code that is there now should be TryStreamExt::try_forward.
Or is there some edge case that I'm missing? Happy to submit a PR if what I described above seems reasonable.
The current implementation of
StreamExt::forward
should actually be inTryStreamExt
astry_forward
, I think, because it requires a fallible stream.StreamExt
should then provide aforward
method that does not require the sink to produceResult
s.In other words the fix that merged in #1946 doesn't much sense to me. The code that was there prior to #1946 should be resurrected as
StreamExt::forward
, as the code that is there now should beTryStreamExt::try_forward
.Or is there some edge case that I'm missing? Happy to submit a PR if what I described above seems reasonable.
/cc @cramertj
The text was updated successfully, but these errors were encountered: