Make Spawn::spawn take &self rather than &mut self
#1950
Merged
+69
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramertj
force-pushed
the
spawn-by-ref
branch
from
78a9e55
to
65bcc52
Compare
Nemo157
approved these changes
Nov 5, 2019
Nemo157
approved these changes
Nov 5, 2019
taiki-e
approved these changes
Nov 5, 2019
cramertj
force-pushed
the
spawn-by-ref
branch
from
65bcc52
to
345f392
Compare
Marwes
added a commit
to Marwes/futures-rs
that referenced
this pull request
Nov 6, 2019
Seems like an oversight in rust-lang#1950 Technically a BREAKING CHANGE
cramertj
pushed a commit
that referenced
this pull request
Nov 7, 2019
Seems like an oversight in #1950 Technically a BREAKING CHANGE
najamelan
added a commit
to najamelan/futures-rs
that referenced
this pull request
Jan 19, 2020
Since rust-lang#1950 (0.3.0) the Spawn and LocalSpawn only require a shared reference for spawning operations. This adds blanket impls for `Arc<Sp: ?Sized + Spawn>` and `Rc<Sp: ?Sized + Spawn>`. It does the same for LocalSpawn. This allows client code to pass an Arc<Exec> when library code takes parameters as `&dyn Spawn` or `impl Spawn`. So far there were blanket impls for `&`, `&mut` and `Box`.
najamelan
added a commit
to najamelan/futures-rs
that referenced
this pull request
Jan 23, 2020
Since rust-lang#1950 (0.3.0) the Spawn and LocalSpawn only require a shared reference for spawning operations. This adds blanket impls for `Arc<Sp: ?Sized + Spawn>` and `Rc<Sp: ?Sized + Spawn>`. It does the same for LocalSpawn. This allows client code to pass an Arc<Exec> when library code takes parameters as `&dyn Spawn` or `impl Spawn`. So far there were blanket impls for `&`, `&mut` and `Box`.
najamelan
added a commit
to najamelan/futures-rs
that referenced
this pull request
Jan 23, 2020
Since rust-lang#1950 (0.3.0) the Spawn and LocalSpawn only require a shared reference for spawning operations. This adds blanket impls for `Arc<Sp: ?Sized + Spawn>` and `Rc<Sp: ?Sized + Spawn>`. It does the same for LocalSpawn. This allows client code to pass an Arc<Exec> when library code takes parameters as `&dyn Spawn` or `impl Spawn`. So far there were blanket impls for `&`, `&mut` and `Box`.
cramertj
pushed a commit
that referenced
this pull request
Jan 23, 2020
Since #1950 (0.3.0) the Spawn and LocalSpawn only require a shared reference for spawning operations. This adds blanket impls for `Arc<Sp: ?Sized + Spawn>` and `Rc<Sp: ?Sized + Spawn>`. It does the same for LocalSpawn. This allows client code to pass an Arc<Exec> when library code takes parameters as `&dyn Spawn` or `impl Spawn`. So far there were blanket impls for `&`, `&mut` and `Box`.
exrook
pushed a commit
to exrook/futures-rs
that referenced
this pull request
Apr 5, 2021
Seems like an oversight in rust-lang#1950 Technically a BREAKING CHANGE
exrook
pushed a commit
to exrook/futures-rs
that referenced
this pull request
Apr 5, 2021
Since rust-lang#1950 (0.3.0) the Spawn and LocalSpawn only require a shared reference for spawning operations. This adds blanket impls for `Arc<Sp: ?Sized + Spawn>` and `Rc<Sp: ?Sized + Spawn>`. It does the same for LocalSpawn. This allows client code to pass an Arc<Exec> when library code takes parameters as `&dyn Spawn` or `impl Spawn`. So far there were blanket impls for `&`, `&mut` and `Box`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1669
r? @Nemo157 @taiki-e @seanmonstar