Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary "nightly" feature #1856

Closed
leeopop opened this issue Sep 2, 2019 · 2 comments
Closed

unnecessary "nightly" feature #1856

leeopop opened this issue Sep 2, 2019 · 2 comments

Comments

@leeopop
Copy link

leeopop commented Sep 2, 2019

Recent change says that "async-await" no longer requires nightly.
However, building alpha.18 version claims that "nightly" feature is not on.
I'm not sure whether removing this feature gate is correct or not, thus simply reporting the compilation error I have.

error: The `async-await` feature requires the `nightly` feature as an explicit opt-in to unstable features
  --> /home/leeopop/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-preview-0.3.0-alpha.18/src/lib.rs:21:1
   |
21 | compile_error!("The `async-await` feature requires the `nightly` feature as an explicit opt-in to unstable features");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@Nemo157
Copy link
Member

Nemo157 commented Sep 2, 2019

This is referring to the nightly cargo feature for the futures crate that was used to gate unstable features (since non-std crates have nothing really like the unstable attribute). That has since been renamed to unstable to make it more obvious and is no longer required when using the async-await feature. Those changes will be in the next alpha release.

@leeopop
Copy link
Author

leeopop commented Sep 3, 2019

Oh, I was working on alpha.18 while looking master's README.
I'm looking forward to see the next release!

@leeopop leeopop closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants