Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Spawn/LocalSpawn from futures-core? #1830

Closed
taiki-e opened this issue Aug 27, 2019 · 3 comments
Closed

Separate Spawn/LocalSpawn from futures-core? #1830

taiki-e opened this issue Aug 27, 2019 · 3 comments
Milestone

Comments

@taiki-e
Copy link
Member

taiki-e commented Aug 27, 2019

I think this trait is not as stable as other futures-core's items like Stream.

Related:

@seanmonstar
Copy link
Contributor

seanmonstar commented Sep 17, 2019

I agree with this, especially with the odd-feeling spawn_obj(FutureObj) method (and the issues you linked). I think it could be moved to futures-executor (and the executor implementations could be made optional, so depending on the crate doesn't require depending on executors you don't use).

It used to need to be part of core, since an executor/spawner was needed to create a Context. But since that was removed, this doesn't need to be part of core.

@taiki-e
Copy link
Member Author

taiki-e commented Sep 18, 2019

I think it could be moved to futures-executor (and the executor implementations could be made optional, so depending on the crate doesn't require depending on executors you don't use).

The executor implementations (LocalPool, ThreadPool) depend on futures-util, futures-util (SpawnExt, Executor01CompatExt, Executor01Future, Executor01As03) depends on Spawn trait, so we need to resolve these circular dependencies.

@cramertj
Copy link
Member

cramertj commented Nov 5, 2019

#1925 has landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants