Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner link to team doesn't link to team #2356

Open
kzhui125 opened this issue Dec 7, 2023 · 2 comments · May be fixed by #2432
Open

owner link to team doesn't link to team #2356

kzhui125 opened this issue Dec 7, 2023 · 2 comments · May be fixed by #2432
Assignees
@Tyrubias
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR

Comments

@kzhui125
Copy link

kzhui125 commented Dec 7, 2023 •
edited by rustbot

https://docs.rs/aes/0.8.3/aes/

image image

the repo is https://github.com/RustCrypto/block-ciphers

url is https://github.com/RustCrypto
@syphar syphar changed the title user doesn't exist owner link to team doesn't link to team Dec 7, 2023
@syphar
Copy link
Member

syphar commented Dec 7, 2023 •
edited

this is actually a bug, it seems like we never started supporting teams with their proper links :)

To wrap up how a solution would look like:

  • RegistryApi::get_owners has to be extended to fetch the kind (team or user) from the crates.io API
  • the kind has to be stored in the database (can we write a migration to backfill the correct kind for existing owners?), see update_owners_in_database.
  • based on the owner kind, we can render a different link in the dropdown (templates/rustdoc/topbar.html )

@syphar syphar added A-frontend Area: Web frontend E-easy Effort: Should be easy to implement and would make a good first PR labels Dec 7, 2023
@syphar syphar added the C-bug Category: This is a bug label Feb 14, 2024
@Tyrubias
Copy link
Contributor

@rustbot claim

@Tyrubias Tyrubias linked a pull request Feb 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyrubias Tyrubias

Labels
A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(topbar): support teams in topbar owner links Tyrubias/docs.rs
3 participants
@syphar @Tyrubias @kzhui125