Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine CUDA support. #712

Merged
merged 3 commits into from Nov 23, 2022
Merged

Refine CUDA support. #712

merged 3 commits into from Nov 23, 2022

Conversation

dot-asm
Copy link
Contributor

@dot-asm dot-asm commented Aug 4, 2022

Instead of counting all source files we count only .cu files, ones with device code that actually require the special treatment.

[Even fixes #641.]

CUDA compiler supports clang++, but it wasn't possible to use it with
cc-rs, because --target option was passed to nvcc instead of clang.
Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but have some minor nits.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Instead of counting all source files we count only .cu files, ones with
device code that actually require the special treatment.
@dot-asm
Copy link
Contributor Author

dot-asm commented Nov 23, 2022

I used the opportunity to update the CUDA toolchain.

Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@thomcc thomcc merged commit 2ce2be8 into rust-lang:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails compiling with cuda
2 participants