Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for riscv32imac-unknown-xous-elf #686

Merged
merged 1 commit into from Oct 26, 2022
Merged

Conversation

xobs
Copy link
Contributor

@xobs xobs commented Jun 9, 2022

The riscv32imac-unknown-xous-elf target is a new Tier 3 platform. This platform uses standard Os-less -none- toolchains, as Rust provides all standard libraries and IPC functionality.

Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems super reasonable.

@thomcc
Copy link
Member

thomcc commented Oct 26, 2022

Can you rebase this? I don't really see how this could break cuda, so it's probably spurious. I don't seem to be able to retrigger on such an old PR though.

(P.S. sorry for the delay for this review, this crate should be more well-maintained going forward)

The `riscv32imac-unknown-xous-elf` target is a new Tier 3 platform.

Signed-off-by: Sean Cross <sean@xobs.io>
@xobs
Copy link
Contributor Author

xobs commented Oct 26, 2022

I had a lot of trouble rebasing it, so I just recreated it and did a force-push. Git can be funny sometimes.

@thomcc
Copy link
Member

thomcc commented Oct 26, 2022

Thanks!

@thomcc thomcc merged commit 8daff16 into rust-lang:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants