Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specify -arch and -m{}os-version-min= on Apple platforms #1030

Open
madsmtm opened this issue Apr 11, 2024 · 3 comments
Open

Don't specify -arch and -m{}os-version-min= on Apple platforms #1030

madsmtm opened this issue Apr 11, 2024 · 3 comments

Comments

@madsmtm
Copy link
Contributor

madsmtm commented Apr 11, 2024

As recommended by Clang developers in llvm/llvm-project#88271 (comment), we already specify --target, and that should be enough.

Related: #1029, the -mxros-version-min/-mvisionos-version-min option does not exist.

CC @BlackHoleFox.

@NobodyXu
Copy link
Collaborator

sounds good to me, IIRC specifying version-min might be related to errors in other projects using cc, maybe even rustc bootstrap, which failed to compile llvm.

@BlackHoleFox
Copy link
Contributor

Yeah ditching it seems like a fine option. Only thought is maybe compatibility with old (whatever matches 10.12) XCode versions but that might not be a real issue since there is no reason to build iOS (and derivative) apps with anything except the last N-2 XCode releases for app store reasons.

Would the idea be to remove use of -m{}os-version-min and -arch everywhere except macOS?

@QuentinPerez
Copy link

Maybe platform_version, it seems to support visionos.

     -platform_version platform min_version sdk_version
             This is set to indicate the platform, oldest supported version of that platform that output is to be used on, and the SDK that the output was
             built against.  platform is a numeric value as defined in <mach-o/loader.h>, or it may be one of the following strings:
             • macos
             • ios
             • tvos
             • watchos
             • bridgeos
             • visionos
             • xros
             • mac-catalyst
             • ios-simulator
             • tvos-simulator
             • watchos-simulator
             • visionos-simulator
             • xros-simulator
             • driverkit
             Specifying a newer min or SDK version enables the linker to assume features of that OS or SDK in the output file. The format of min_version
             and sdk_version is a version number such as 10.13 or 10.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants