Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-stabilization documentation for workspace inheritance #10659

Merged
merged 1 commit into from May 12, 2022

Conversation

Muscraft
Copy link
Contributor

This is adding documentation for how we would like users to test workspace inheritance.

This came about from a discussion between @epage and I on better ways to document "pre-stabilization" features that are looking for people to test them. One of the ideas was to add some of the documentation to unstable.md so that it is all in one area. Having it in one area allows us to link to it so there are testing notes and documentation in one place. It also helps when posting in various places looking for testers as we can link to the nightly docs as needed. One idea was to post in TWiR under a new table and this also helps with this.

The new documentation covers

  • What we are looking for from testers
  • Where to give feedback
  • How to test this feature
  • An example port as a guide

r? @epage

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 11, 2022
src/doc/src/reference/unstable.md Outdated Show resolved Hide resolved
src/doc/src/reference/unstable.md Outdated Show resolved Hide resolved
src/doc/src/reference/unstable.md Outdated Show resolved Hide resolved
src/doc/src/reference/unstable.md Show resolved Hide resolved
src/doc/src/reference/unstable.md Outdated Show resolved Hide resolved
src/doc/src/reference/unstable.md Outdated Show resolved Hide resolved
src/doc/src/reference/unstable.md Outdated Show resolved Hide resolved
@Muscraft Muscraft force-pushed the prestabilization-inheritance-docs branch from 83796f0 to b3b2368 Compare May 11, 2022 21:29
@Muscraft Muscraft force-pushed the prestabilization-inheritance-docs branch from b3b2368 to 8816272 Compare May 12, 2022 14:57
src/doc/src/reference/unstable.md Outdated Show resolved Hide resolved
@Muscraft Muscraft force-pushed the prestabilization-inheritance-docs branch from 8816272 to 6892cc3 Compare May 12, 2022 15:13
@epage
Copy link
Contributor

epage commented May 12, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented May 12, 2022

📌 Commit 6892cc3 has been approved by epage

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2022
@bors
Copy link
Collaborator

bors commented May 12, 2022

⌛ Testing commit 6892cc3 with merge 3f052d8...

@bors
Copy link
Collaborator

bors commented May 12, 2022

☀️ Test successful - checks-actions
Approved by: epage
Pushing 3f052d8 to master...

@bors bors merged commit 3f052d8 into rust-lang:master May 12, 2022
@Muscraft Muscraft deleted the prestabilization-inheritance-docs branch May 12, 2022 16:06
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2022
Update cargo

20 commits in a44758ac805600edbb6ba51e7e6fb81a6077c0cd..3f052d8eed98c6a24f8b332fb2e6e6249d12d8c1
2022-05-04 02:29:34 +0000 to 2022-05-12 15:19:04 +0000
- pre-stabilization documentation for workspace inheritance (rust-lang/cargo#10659)
- test: Make curr_dir work in/out of workspace (rust-lang/cargo#10658)
- Fix no_cross_doctests race condition. (rust-lang/cargo#10660)
- Fix typo (rust-lang/cargo#10657)
- feat(install): Support `foo@version` like cargo-add (rust-lang/cargo#10650)
- fix typos found by the `typos-cli` crate (rust-lang/cargo#10649)
- feat(yank): Support foo@version like cargo-add (rust-lang/cargo#10597)
- add `cargo-features` to unstable docs for workspace inheritance (rust-lang/cargo#10648)
- Use the traits added to the Rust 2021 Edition prelude (rust-lang/cargo#10646)
- Pass `--target` to `rustdoc` for `cargo test` if specified with host target. (rust-lang/cargo#10594)
- Fix use of .. in dep-info-basedir (rust-lang/cargo#10281)
- fix some typos (rust-lang/cargo#10639)
- Move snapshot tests into testsuite (rust-lang/cargo#10638)
- Improve support of condition compilation checking (rust-lang/cargo#10566)
- When documenting private items in a binary, ignore warnings about links to private items (rust-lang/cargo#10142)
- Extend pkgid syntax with ``@`` support (rust-lang/cargo#10582)
- move one `snapshot/add` test into `testsuite/cargo_add/` (rust-lang/cargo#10631)
- Add caveat for covering features (rust-lang/cargo#10605)
- Improve CARGO_ENCODED_RUSTFLAGS and CARGO_ENCODED_RUSTDOCFLAGS variables docs (rust-lang/cargo#10633)
- reorganize `snapshot` tests to better work in contexts that sort by extension (rust-lang/cargo#10629)
@ehuss ehuss added this to the 1.62.0 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants