Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C/C++ module file and line number are not looked up: addr2line 0.18.0 fixes it #492

Merged
merged 1 commit into from Nov 8, 2022

Conversation

bsekura
Copy link
Contributor

@bsekura bsekura commented Nov 8, 2022

OS: Linux

In a project with mixed C/C++ and Rust (e.g. embedding Rust in C/C++), backtrace does not correctly look up file and line numbers for symbols in C/C++ modules. Upgrading addr2line to 0.18.0 fixes it.

In a simple test project where C/C++ code calls the following Rust function

#[no_mangle]
pub extern "C" fn do_backtrace() {
    backtrace::trace(|frame| {
        backtrace::resolve_frame(frame, |symbol| {
            println!("{:?}", symbol);
        });

        true
    });
}

The results are:

Symbol { name: backtrace::backtrace::libunwind::trace::hc00fd2caa393a231, addr: 0x1be63c, filename: "/home/bart/dev/rust/backtrace-rs-fork/src/backtrace/libunwind.rs", lineno: 93 }
Symbol { name: backtrace::backtrace::trace_unsynchronized::h6193cc2c5c3617b2, addr: 0x1be63c, filename: "/home/bart/dev/rust/backtrace-rs-fork/src/backtrace/mod.rs", lineno: 66 }
Symbol { name: backtrace::backtrace::trace::he8dde40ef7a49457, addr: 0x1be776, filename: "/home/bart/dev/rust/backtrace-rs-fork/src/backtrace/mod.rs", lineno: 53 }
Symbol { name: "do_backtrace", addr: 0x3ddd5, filename: "/home/bart/dev/temp/zzz/rust_zzz/src/lib.rs", lineno: 8 }
Symbol { name: "_ZL10dump_stackb" }
Symbol { name: "_ZL16another_functionb" }
Symbol { name: "_ZL13some_functionb" }
Symbol { name: "main" }
Symbol { name: "__libc_start_main" }
Symbol { name: "_start", addr: 0x3dac4, filename: "/build/glibc/src/glibc/csu/../sysdeps/x86_64/start.S", lineno: 115 }

After upgrading addr2line version to 0.18.0, the results are correct:

Symbol { name: backtrace::backtrace::libunwind::trace::h0273b8e83debf323, addr: 0x2806ac, filename: "/home/bart/dev/rust/backtrace-rs-fork/src/backtrace/libunwind.rs", lineno: 93 }
Symbol { name: backtrace::backtrace::trace_unsynchronized::hfc31d3d1f9e4ee76, addr: 0x2806ac, filename: "/home/bart/dev/rust/backtrace-rs-fork/src/backtrace/mod.rs", lineno: 66 }
Symbol { name: backtrace::backtrace::trace::heabc35a113e1a579, addr: 0x2807e6, filename: "/home/bart/dev/rust/backtrace-rs-fork/src/backtrace/mod.rs", lineno: 53 }
Symbol { name: "do_backtrace", addr: 0x4add5, filename: "/home/bart/dev/temp/zzz/rust_zzz/src/lib.rs", lineno: 8 }
Symbol { name: "_ZL10dump_stackb", addr: 0x4acf4, filename: "/home/bart/dev/temp/zzz/src/main.cpp", lineno: 30 }
Symbol { name: "_ZL16another_functionb", addr: 0x4acac, filename: "/home/bart/dev/temp/zzz/src/main.cpp", lineno: 50 }
Symbol { name: "_ZL13some_functionb", addr: 0x4ac7c, filename: "/home/bart/dev/temp/zzz/src/main.cpp", lineno: 55 }
Symbol { name: "main", addr: 0x4abeb, filename: "/home/bart/dev/temp/zzz/src/main.cpp", lineno: 64 }
Symbol { name: "__libc_start_main" }
Symbol { name: "_start", addr: 0x4aac4, filename: "/build/glibc/src/glibc/csu/../sysdeps/x86_64/start.S", lineno: 115 }

@alexcrichton alexcrichton merged commit 6c1d4ac into rust-lang:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants